Merged
Conversation
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
✅ Deploy Preview for mitre-saf-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
| on: | ||
| push: | ||
| branches: | ||
| - main |
Member
There was a problem hiding this comment.
This should not have to change as PRs automatically get deploy previews
Contributor
Author
There was a problem hiding this comment.
using for testing only - for some reason the theme configuration is not working properly when switching from light to dark mode, both images are displayed (see page 7) locally it works as expected.
Contributor
There was a problem hiding this comment.
Was told to share this with you. Upstream continues to make breaking changes. You might want to see if changing where the setting was placed fixes your issue that you're having.
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M. Dias <gdias@mitre.org>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
aaronlippold
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement proposed modification reviewed by Emily on 12-Dec-2024