Feat/ironbank mr workflow#736
Open
wdower wants to merge 9 commits into
Open
Conversation
Updates the Nov 2025 3NF redesign plan with: - All shipped work since v1 (Blueprinter, VulcanAuditable, reviews expansion, comment phase, triage context panel, seed modernization) - 3-agent expert review findings (DB design, Rails/AR, PostgreSQL perf) - Critical fixes: matview trigger replaced with async, rescue nil replaced with respond_to?, override NULL semantics clarified, reviews Phase 2.5 migration added - Blueprint coverage assessment + migration plan per phase - Claude-pace estimates replacing human-hour estimates Authored by: Aaron Lippold<lippold@gmail.com>
Adds three problem entries under MODERATE: Performance Issues: - Problem 11: set_component eager_load cartesian explosion + review-author N+1 (PRODUCTION HOTSPOT). Latent since #286; #729's comment volume triggered the multiplier in prod (500-1000ms component-page hits, can drive Puma R14 / indirect instance-wide slowdown). - Problem 12: check_access_request_notifications unbounded per-request query (PRODUCTION HOTSPOT). Super admin path loads the entire project_access_requests table on every HTML request; scales with new-user onboarding. - Problem 13: polymorphic-commentable correctness regressions in Component#reviews and Component.pending_comment_counts (CORRECTNESS REGRESSION). Both still scope to rule-only commentables and silently undercount component-scoped reviews shipped in #729. Each entry proposes a tactical fix that ships independently of the redesign phases. Signed-off-by: Will <will@dower.dev>
…thors Kills the eager_load cartesian product (rules x reviews x checks x ...) and the ReviewBlueprint user N+1 in RuleBlueprint :editor. See docs/plans/DATABASE-COMPLETE-REDESIGN-v2.md Problem 11. Signed-off-by: Will <will@dower.dev>
Super admin path loaded the entire project_access_requests table on every HTML request. Adds NAVBAR_ACCESS_REQUESTS_CAP, newest-first ordering. See docs/plans/DATABASE-COMPLETE-REDESIGN-v2.md Problem 12. Signed-off-by: Will <will@dower.dev>
…g counts Both methods scoped to rule-only commentables and silently dropped component-scoped reviews shipped in #729. Rewrites as polymorphic UNIONs. See docs/plans/DATABASE-COMPLETE-REDESIGN-v2.md Problem 13. Signed-off-by: Will <will@dower.dev>
- Rollback strategy: per-phase expand-contract plan with checkpoints - Post-migration validation: db:validate rake task (FKs, NULLs, dupes) - Performance benchmarks: db:benchmark rake task with target thresholds - ORM evaluation: Drizzle recommended over Prisma (40-60% raw SQL fallback rate with Prisma vs 10-15% with Drizzle for this schema) - Drizzle ecosystem assessment for compliance app needs Authored by: Aaron Lippold<lippold@gmail.com>
…oncern Phase 0 (prep harness): - db:benchmark rake task for capturing per-endpoint perf baselines - db:validate rake task: orphan/NULL/dup checks, guarded by table existence so it's meaningful at every migration phase, exits non-zero for CI gating - QueryCounter spec helper for bounded-query N+1 assertions Phase 1 (DisplayFallback, additive, no schema change): - app/models/concerns/display_fallback.rb: display_title/fixtext/ident/severity + generic display_field resolve own value -> _override accessor -> SRG template. Uses respond_to? guards (not rescue nil). with_display_fallbacks eager-loads :srg_rule. has_overrides? / override_summary report divergence from template. - Rule includes DisplayFallback - RuleBlueprint routes title/severity (default) and fixtext/ident (viewer) through display_* — no-op while rules copy template content, but lets later phases null duplicated columns without breaking the API. Stays N+1-free. Establishes the override-not-copy fallback pattern ahead of the STI split. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…s/stig_rules Splits the STI base_rules table into three concrete tables and repoints polymorphic content + review/audit references at the new `rules` table. Work in progress: Phase 2/2.5 migrations, models, and specs in flight; suite not yet fully green. - migrations: split_base_rules_sti, migrate_review_fks_to_rules - models: BaseRule abstract_class; Rule/SrgRule/StigRule own tables; Check/Reference/RuleDescription/DisaRuleDescription polymorphic on base_rule - DisplayFallback override pattern on Rule - severity_counts per-type table; SQL refs base_rules → rules across component/project/review/search - specs updated to 'Rule'/'rules' end-state expectations Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds an automated Iron Bank (repo1.dso.mil) release step to the
docker-release job, modelled on mitre/heimdall2's release-server-to-docker
workflow. On each published GitHub release, after the multi-arch
mitre/vulcan image is built and pushed, it files a GitLab issue + MR
against Vulcan's Iron Bank mirror (project 17073) bumping the manifest
to the freshly published image.
- Uses mitre/ironbank_release_action@v1 (SHA-pinned).
- Version comes from docker/metadata-action's {{version}} output (semver,
v-stripped) — equivalent to Heimdall's format-tag preprocessing.
- Resolves per-architecture digests (resources[0]=amd64, resources[1]=arm64)
via `docker buildx imagetools inspect`, since build-push-action only
exposes the multi-arch index digest.
- update_commands escapes double-quotes for the action's `eval`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the release workflow for creating an MR on repo1 when we publish a new Vulcan version. Uses mitre/ironbank_release_action marketplace action.