Make Widget::set_size() virtual#157
Open
mode777 wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
Conversation
Disclaimer: I know very little about C++. That said: set_size() is overridden in Screen but set_size() was not marked as virtual leading to the overridden method not being called correctly. Adding the virtual keyword fixes the issue for me.
|
This can be closed. Screens set_size() calls Widget::set_size() directly. |
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
19 times, most recently
from
2f2e29f to
9d91e56
Compare
wjakob
force-pushed
the
master
branch
6 times, most recently
from
c75898b to
1bbd038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I know very little about C++. That said: set_size() is overridden in Screen but set_size() was not marked as virtual leading to the overridden method not being called correctly. Adding the virtual keyword fixes the issue for me.