A few additions to the Button class#171
Open
palszasz wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
A few additions to the Button class#171palszasz wants to merge 1 commit intomitsuba-renderer:masterfrom
palszasz wants to merge 1 commit intomitsuba-renderer:masterfrom
Conversation
palszasz
commented
Jun 12, 2025
palszasz
commented
- Added “flat” attribute: if set, the button background and outline is not rendered (except the outline is rendered when the mouse is hovering above it). This can be used to remove UI clutter.
- Added attributes for the button padding. This allows to create more compact buttons, without setting a fixed size.
- Note that the new attributes should not increase sizeof(Button), since they were inserted in wasted space due to alignment (and that’s one reason why the padding is stored in 8-bit: it’s still big enough, but we don’t waste additional space... assuming bool is one byte)
* Added “flat” attribute: if set, the button background and outline is not rendered (except the outline is rendered when the mouse is hovering above it). This can be used to remove UI clutter. * Added attributes for the button padding. This allows to create more compact buttons, without setting a fixed size. * Note that the new attributes should not increase sizeof(Button), since they were inserted in wasted space due to alignment (and that’s one reason why the padding is stored in 8-bit: it’s still big enough, but we don’t waste additional space... assuming bool is one byte)
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
20 times, most recently
from
e9b125b to
54dc5d6
Compare
wjakob
force-pushed
the
master
branch
5 times, most recently
from
c75898b to
1bbd038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.