Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest jom for test #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use latest jom for test #892

wants to merge 1 commit into from

Conversation

xavier2k6
Copy link
Contributor

@miurahr
Copy link
Owner

miurahr commented Feb 20, 2025

A change of jom version may bring the test failure which the case use jom. Please check it.

@xavier2k6 xavier2k6 force-pushed the aqt_test_jom branch 5 times, most recently from 8633439 to 81e1e9e Compare February 20, 2025 20:54
@xavier2k6 xavier2k6 marked this pull request as draft February 20, 2025 20:55
@xavier2k6 xavier2k6 force-pushed the aqt_test_jom branch 3 times, most recently from 55c7302 to 551bc0e Compare February 20, 2025 21:58
@pzhlkj6612
Copy link
Contributor

Interesting, the entire Qt seems to be gone:

jom 1.1.4 - empower your cores

	D:\a\1\b\Qt\6.5.3\msvc2019_arm64\bin\jom.exe -f Makefile.Release
	cl -c -nologo -Zc:wchar_t -FS -Zc:rvalueCast -Zc:inline -Zc:strictStrings -Zc:throwingNew -permissive- -Zc:__cplusplus -Zc:externConstexpr -O2 -MD -std:c++17 -utf-8 -W3 -w34100 -w34189 -w44996 -w44456 -w44457 -w44458 -wd4577 -wd4467 -EHsc -DUNICODE -D_UNICODE -DWIN32 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -DWIN64 -DWIN64 -DNDEBUG -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -Itests\helloworld -I. -IQt\6.5.3\msvc2019_arm64\include -IQt\6.5.3\msvc2019_arm64\include\QtWidgets -IQt\6.5.3\msvc2019_arm64\include\QtGui -IQt\6.5.3\msvc2019_arm64\include\QtCore -Irelease -I/include -IQt\6.5.3\msvc2019_arm64\mkspecs\win32-arm64-msvc -Forelease\ @C:\Users\VSSADM~1\AppData\Local\Temp\main.obj.940.0.jom
main.cpp
	link /NOLOGO /DYNAMICBASE /NXCOMPAT /OPT:REF /OPT:ICF /INCREMENTAL:NO /SUBSYSTEM:WINDOWS "/MANIFESTDEPENDENCY:type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture='*'" /MANIFEST:embed /OUT:release\Hello.exe @C:\Users\VSSADM~1\AppData\Local\Temp\Hello.exe.940.10297.jom
main.obj : error LNK2001: unresolved external symbol __imp_qt_version_tag_6_5
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl QString::~QString(void)" (__imp_??1QString@@QEAA@XZ) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl QString::QString(char const *)" (__imp_??0QString@@QEAA@PEBD@Z) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl QApplication::QApplication(int &,char * *,int)" (__imp_??0QApplication@@QEAA@AEAHPEAPEADH@Z) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __cdecl QApplication::~QApplication(void)" (__imp_??1QApplication@@UEAA@XZ) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static int __cdecl QApplication::exec(void)" (__imp_?exec@QApplication@@SAHXZ) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl QWidget::show(void)" (__imp_?show@QWidget@@QEAAXXZ) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl QPushButton::QPushButton(class QString const &,class QWidget *)" (__imp_??0QPushButton@@QEAA@AEBVQString@@PEAVQWidget@@@Z) referenced in function main
main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __cdecl QPushButton::~QPushButton(void)" (__imp_??1QPushButton@@UEAA@XZ) referenced in function main
main.obj : error LNK2001: unresolved external symbol "public: __cdecl QString::~QString(void)" (??1QString@@QEAA@XZ)
main.obj : error LNK2001: unresolved external symbol "public: virtual __cdecl QApplication::~QApplication(void)" (??1QApplication@@UEAA@XZ)
main.obj : error LNK2001: unresolved external symbol "public: virtual __cdecl QPushButton::~QPushButton(void)" (??1QPushButton@@UEAA@XZ)
MSVCRT.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl __scrt_common_main_seh(void)" (?__scrt_common_main_seh@@YAHXZ)
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Widgets.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Gui.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Core.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6EntryPoint.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
release\Hello.exe : fatal error LNK1120: 13 unresolved externals
jom: D:\a\1\b\Makefile.Release [release\Hello.exe] Error 1120

The Qt version update in "tests/test_install.py" looks unrelated to this PR, btw.

@xavier2k6
Copy link
Contributor Author

xavier2k6 commented Feb 21, 2025 •
edited
Loading

The Qt version update in "tests/test_install.py" looks unrelated to this PR, btw.

Acknowledged, had just made the changes for testing purposes & they will be reverted.

Any help would be appreciated with regards to this PR.

maybe this change should be done inline with #883

@pzhlkj6612
Copy link
Contributor

I think you can revert the Qt version for now and see what will happen.

@xavier2k6
Copy link
Contributor Author

xavier2k6 commented Feb 21, 2025 •
edited
Loading

I think you can revert the Qt version for now and see what will happen.

Reverted to Qt 6.5.2 in "tests/test_install.py"

Changed azure matrix Qt version from 6.5.3 to 6.8.0 6.7.3 for testing purposes. (6.8+ has no msvc2019 binaries)

@xavier2k6 xavier2k6 force-pushed the aqt_test_jom branch 2 times, most recently from 8b368ab to 679ce02 Compare February 22, 2025 10:36
@xavier2k6
Copy link
Contributor Author

azure pipelines seem to be unavailable/not running now?

@pzhlkj6612
Copy link
Contributor

Hmm, force-pushing drops old commits and old logs... @xavier2k6, the commits in a PR can be squashed during merge 1, so you can feel free to push anything.

D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Widgets.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Gui.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6Core.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'
D:\a\1\b\Qt\6.5.3\msvc2019_arm64\lib\Qt6EntryPoint.lib : warning LNK4272: library machine type 'ARM64' conflicts with target machine type 'x64'

I think we need to look closer at msvc2019_arm64 . Let's solve it in another PR.

Footnotes

  1. About merge methods on GitHub - GitHub Docs https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/about-merge-methods-on-github ↩

@pzhlkj6612
Copy link
Contributor

@miurahr, I think we can embed the checksum of the ZIP package in our workflow and then check its integrity before extraction. The official list: https://download.qt.io/official_releases/jom/md5sums.txt

@xavier2k6 xavier2k6 marked this pull request as ready for review February 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavier2k6 @miurahr @pzhlkj6612