fix: register click/change/submit listeners in capture phase - Needed for RN Web - #586
Open
tylerjroach wants to merge 1 commit into
Open
fix: register click/change/submit listeners in capture phase - Needed for RN Web#586tylerjroach wants to merge 1 commit into
tylerjroach wants to merge 1 commit into
Conversation
…hase Bubble-phase listeners on window are silenced when downstream component code calls event.stopPropagation(). React Native Web's PressResponder does this unconditionally on every onClick, breaking autocapture for all RNW-rendered components. Capture-phase listeners fire before any component handler runs, so stopPropagation() in bubble cannot reach them. Applied to all five user-interaction listeners: click, dead-click, rage-click, input change, and form submit. Matching removeEventListener calls also updated since browsers treat capture and bubble registrations as separate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jakewski
approved these changes
May 18, 2026
jakewski
left a comment
Collaborator
There was a problem hiding this comment.
thanks will get this in next release
jakewski
pushed a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers click/change/submit listeners in capture phase
Bubble-phase listeners on window are silenced when downstream component
code calls event.stopPropagation(). React Native Web's PressResponder
does this unconditionally on every onClick, breaking autocapture for
all RNW-rendered components. Capture-phase listeners fire before any
component handler runs, so stopPropagation() in bubble cannot reach them.
Applied to all five user-interaction listeners: click, dead-click,
rage-click, input change, and form submit. Matching removeEventListener
calls also updated since browsers treat capture and bubble registrations
as separate.