Rewrote introduction of the Vinyl Control chapter - #783
Conversation
df51c85 to
1cdaa60
Compare
ywwg
left a comment
ywwg
left a comment
There was a problem hiding this comment.
thanks for updating this text -- I would like to make sure to clarify the sentence in the introduction that makes it sound like the vinyl control code applies to all spinning-wheel controllers, which is not the case.
| Jörg Wartenberg <joerg.wartenberg@mixxx.org> | ||
|
|
||
| The Vinyl Control functionality allows users to tweak the playback speed of a track | ||
| in Mixxx using a traditional turntable or a DJ player with a platter to spin. |
There was a problem hiding this comment.
what do you mean "a DJ player with a platter to spin"? This could refer to spinning-wheel controllers, which are not driven by the DVS code.
There was a problem hiding this comment.
I see that this PR was merged before I had a chance to review it, but I think this line is confusing enough that we should change it.
There was a problem hiding this comment.
I stumbled over this as well but the table calirifies it sufficiently IMO.
There was a problem hiding this comment.
What I tried to express is that this category covers DJ players with a rotating platter, either with a non-motorized platter like a PioneerDJ CDJ1000 or DJ players with a motorized platter like a DenonDJ SC5000M.
It would be great if you as native Englisch speaker could propose an better wording.
4 participants
@ywwg As first step of updating the Vinyl Control chapter, I rewrote the introduction section.