Skip to content

Document additional metadata variables for Broadcasting - #806

Merged
ronso0 merged 1 commit into
mixxxdj:mainfrom
Owen-Turnbull:patch-2
Oct 30, 2025
Merged

Document additional metadata variables for Broadcasting#806
ronso0 merged 1 commit into
mixxxdj:mainfrom
Owen-Turnbull:patch-2

Conversation

@Owen-Turnbull

@Owen-Turnbull Owen-Turnbull commented Oct 28, 2025 •
edited by ronso0
Loading

Copy link
Copy Markdown

ronso0
ronso0 reviewed Oct 28, 2025
View reviewed changes

@ronso0 ronso0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I left a note

Comment thread source/chapters/livebroadcasting.rst Outdated
@Owen-Turnbull
Owen-Turnbull requested a review from ronso0 October 29, 2025 04:43
ronso0
ronso0 reviewed Oct 29, 2025
View reviewed changes
Comment thread source/chapters/livebroadcasting.rst Outdated
@Owen-Turnbull

Owen-Turnbull commented Oct 29, 2025

Copy link
Copy Markdown
Author

@ronso0 Is there a way to run this before I request review? I have pre-commit...

@Owen-Turnbull
Owen-Turnbull requested a review from ronso0 October 29, 2025 16:50
@ronso0

ronso0 commented Oct 29, 2025

Copy link
Copy Markdown
Member

Not sure what you mean by "run this"?
It looks good, CI is happy I think 🤷‍♂️

Do you mean build the html or pdf?

@Owen-Turnbull

Owen-Turnbull commented Oct 29, 2025

Copy link
Copy Markdown
Author

@ronso0 Yes, I was just wondering if I could run these checks/actions for CI before creating PR or requesting review. It seems like the README has the solution for building PDF and HTML.

@ronso0

ronso0 commented Oct 29, 2025

Copy link
Copy Markdown
Member

Well, you should have pre-commit installed.
Afaiu CI on Github also runs the link check, and it's automatically updated.

Having to do fixups on Github is no big deal IMO, neither for devs nor contributors. We can always fixup/squash/rebase at the end if there are issues. The Compare link after a force-push allows to view the changes.
I wouldn't mind too much.

@ronso0

ronso0 commented Oct 29, 2025

Copy link
Copy Markdown
Member

Btw mixxxdj/mixxx#15540 went to main

@ronso0
ronso0 changed the base branch from 2.5 to main October 29, 2025 23:50
@ronso0

ronso0 commented Oct 29, 2025

Copy link
Copy Markdown
Member

I changed the target here, please rebase onto main and force-push.
Thanks!

@Owen-Turnbull @ronso0
Document additional metadata variables for broadcasting
24fe591 
Co-authored-by: ronso0 <ronso0@mixxx.org>
@ronso0

ronso0 commented Oct 30, 2025

Copy link
Copy Markdown
Member

Thank you, LGTM

@ronso0
ronso0 merged commit 1d6f79a into mixxxdj:main Oct 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronso0 ronso0 ronso0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Owen-Turnbull @ronso0