Skip to content

chore: migrate hardware manual to Markdown (part 2)#891

Open
acolombier wants to merge 8 commits into
mixxxdj:2.6from
acolombier:chore/migrate-to-markdown
Open

chore: migrate hardware manual to Markdown (part 2)#891
acolombier wants to merge 8 commits into
mixxxdj:2.6from
acolombier:chore/migrate-to-markdown

Conversation

@acolombier

Copy link
Copy Markdown
Member

Follow up on #867, extracted from #855

@JoergAtGithub

Copy link
Copy Markdown
Member

Please fix the build check fails!
Are there any significiant sections taken from the Wiki?

@acolombier acolombier force-pushed the chore/migrate-to-markdown branch from ad0a2ce to 36d295f Compare June 20, 2026 21:32
@acolombier

acolombier commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

Please fix the build check fails!

Just forced pushed a fix, looks like some syntax messed sneaked in.
PDF is still borken, I will investigate later.

Are there any significiant sections taken from the Wiki?

None! This aims to be a "content perfect" migration, so we can simplify the review of #855 later.
For disclosure, I have used an agentic approach and used Playwright MCP for the success loop. It would compare the rendering of the local server (using sphinx-autobuild) and the 2.6 server.

Note that it isn't perfect. I could see some mild discrepancy so it will still need a human review to catch those regressions that we consider problematic.

@ronso0 ronso0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some fixes for broken links I noticed

Comment thread source/hardware/controllers/american_audio_vms2.md Outdated
Comment thread source/hardware/controllers/behringer_bcr2000.md Outdated
Comment thread source/hardware/controllers/behringer_ddm4000.md Outdated
@acolombier

acolombier commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

Thanks @ronso0 !

I spend a good three hours to do a side by side comparison and update small details to get a near pixel perfect migration (+ fixing rendering issues in the live version).

I had to do two side chnages which are:

Out of the thirty manual updates, here are my notes for future content improvement

hercules_dj_console_4_mx: Need some care for better rendering (likely automat-able with agentic workflow)
hercules_dj_console_rmx: Fixed random spaces in words
hercules_dj_console_rmx: Need some care for better rendering, especially hwlabel (likely automat-able with agentic workflow)
hercules_p32_dj: fixed image not correctly defined
numark_mixtrack: Need some care for better rendering (likely automat-able with agentic workflow)
numark_mixtrack_platinum: not exactly the same rendering as the original rendering, fixed some issues with bottom lists

Note that I found some content that had been changed by the AI beside the strict rules around respecting a perfect content migration. I have removed those.

Something remains wrong with the PDF build but not sure what. I need to investigate further.
Edit: seem to be failing on 2.6 already?

@acolombier acolombier force-pushed the chore/migrate-to-markdown branch from e1789be to 2b5a411 Compare June 21, 2026 23:13
@ronso0

ronso0 commented Jun 22, 2026

Copy link
Copy Markdown
Member

I spend a good three hours to do a side by side comparison and update small details to get a near pixel perfect migration (+ fixing rendering issues in the live version).

Thank you!

So, in terms of review, we'd do just a quick side-by-side check?

And the wiki pages are postponed until we figure the license situation? (as @JoergAtGithub proposed)

@acolombier

Copy link
Copy Markdown
Member Author

So, in terms of review, we'd do just a quick side-by-side check?

Yep! I have done it already, but a quick check would be good to confirm I didn't miss anything!

And the wiki pages are postponed until we figure the license situation? (as @JoergAtGithub proposed)

Absolutely, once I will have rebased the wiki migration PR, we should see much clearer as it will reduce the diff set quite a bit and we then decide if there is info worth keeping in (e.g with a AI-enabled rewrite) or simply noise/redundant and drop it, thus consider the Wiki entry as not adding any value (disclaimer, I think this is the case for +90% of it :D )

@acolombier

Copy link
Copy Markdown
Member Author

Ok, everything is fixed. Had to make some fixes to l10n and latex rendering engine since the Markdown plugin (MyST) is more strict about certain errors (e.g not tolerating invalid roles).
We could probably disable those, but I thought this was a great opportunity to clean it up.
Also, only 2 dead link (which aren't actually dead, but blocked because coming from GH CIDR), which is the smallest I have ever seen on the repo 😆

@JoergAtGithub

Copy link
Copy Markdown
Member

Does it work to edit translated strings here? Wouldn't the next tranifex update overwrite them with the old string again?

@acolombier

Copy link
Copy Markdown
Member Author

I think it would, I believe we would need to import those fix back into Transifex, before further edits are made!
At the moment, since there were breaking the build, I was left with no choice but fixing it, but we should do the import as fast as possible so no community edit occurs.
Not sure how to do that?

@acolombier acolombier force-pushed the chore/migrate-to-markdown branch from 269175c to 51cb8cb Compare June 22, 2026 23:53
@ronso0

ronso0 commented Jun 23, 2026

Copy link
Copy Markdown
Member

I think it would, I believe we would need to import those fix back into Transifex, before further edits are made!
At the moment, since there were breaking the build, I was left with no choice but fixing it, but we should do the import as fast as possible so no community edit occurs.
Not sure how to do that?

It is the wrong appraoch to change the .po files manually. It should suffice to change the sources only (.rst files), then update/regerate the tr templates and push to Transifex.
I think the process is described here https://github.com/mixxxdj/manual#maintaining-translations

@acolombier

Copy link
Copy Markdown
Member Author

The problem is there was strings that where translated in Transiflex already, which should remain in English.

Example:

  • :menuselection:`Preferences ...` -> :menuselectie:`Voorkeuren...` (see the role :menuselection: has been translated)
  • |ic_lib_computer| This mode works... -> |ic_lib_ordinateur| Ce mode fonctionne... (see the icon role has been translated)

Happy to revert the commit otherwise but this will fail the build. I can perhaps try to filter the error with suppress_warnings or similar tho but note that translation breaks the page rendering currently anyway.

Happy to also report those fixes to Transiflex but I don't think I have access.

@daschuer

Copy link
Copy Markdown
Member

Happy to also report those fixes to Transiflex but I don't think I have access.

Anyone has access. I just went ahead and fixed it there for all Versions.
For updating it to 2.6, we need to merge #708 first.

@acolombier

Copy link
Copy Markdown
Member Author

Good to know! I am really not familiar with the setup regarding i18n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants