chore: migrate hardware manual to Markdown (part 2)#891
Conversation
|
Please fix the build check fails! |
ad0a2ce to
36d295f
Compare
Just forced pushed a fix, looks like some syntax messed sneaked in.
None! This aims to be a "content perfect" migration, so we can simplify the review of #855 later. Note that it isn't perfect. I could see some mild discrepancy so it will still need a human review to catch those regressions that we consider problematic. |
ronso0
left a comment
There was a problem hiding this comment.
just some fixes for broken links I noticed
|
Thanks @ronso0 ! I spend a good three hours to do a side by side comparison and update small details to get a near pixel perfect migration (+ fixing rendering issues in the live version). I had to do two side chnages which are:
Out of the thirty manual updates, here are my notes for future content improvement
Note that I found some content that had been changed by the AI beside the strict rules around respecting a perfect content migration. I have removed those. Something remains wrong with the PDF build but not sure what. I need to investigate further. |
e1789be to
2b5a411
Compare
Thank you! So, in terms of review, we'd do just a quick side-by-side check? And the wiki pages are postponed until we figure the license situation? (as @JoergAtGithub proposed) |
Yep! I have done it already, but a quick check would be good to confirm I didn't miss anything!
Absolutely, once I will have rebased the wiki migration PR, we should see much clearer as it will reduce the diff set quite a bit and we then decide if there is info worth keeping in (e.g with a AI-enabled rewrite) or simply noise/redundant and drop it, thus consider the Wiki entry as not adding any value (disclaimer, I think this is the case for +90% of it :D ) |
|
Ok, everything is fixed. Had to make some fixes to l10n and latex rendering engine since the Markdown plugin (MyST) is more strict about certain errors (e.g not tolerating invalid roles). |
|
Does it work to edit translated strings here? Wouldn't the next tranifex update overwrite them with the old string again? |
|
I think it would, I believe we would need to import those fix back into Transifex, before further edits are made! |
269175c to
51cb8cb
Compare
It is the wrong appraoch to change the .po files manually. It should suffice to change the sources only (.rst files), then update/regerate the tr templates and push to Transifex. |
|
The problem is there was strings that where translated in Transiflex already, which should remain in English. Example:
Happy to revert the commit otherwise but this will fail the build. I can perhaps try to filter the error with Happy to also report those fixes to Transiflex but I don't think I have access. |
Anyone has access. I just went ahead and fixed it there for all Versions. |
|
Good to know! I am really not familiar with the setup regarding i18n |
Follow up on #867, extracted from #855