KORG KAOSS DJ Revamp - #11639
Conversation
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
mostly lgtm. some of the new parts could be a little DRYer, are you interested in some suggestions or do you just want this merged?
Yes please. I have tried to simplify the code a bit without rewriting it while preserving the proposed behavior. |
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
Anything more would involve quite large refactorings unfortunately.
|
Hey, |
I only cleaned up the code a bit and fixed/removed non-working parts as a starting point for future improvements. |
<TAP> : open folder <TAP> + <TAP> : double-tap to close folder <SHIFT LEFT> + <TAP> : tap bpm of LEFT track <SHIFT RIGHT> + <TAP> : tap bpm of RIGHT track <browseKnob> : browse library up & down <SHIFT> + <browseKnob> : toggle focus between Playlist and File-Browser <LOAD A/B> : load track <SHIFT> + <LOAD A/B> : open/close folder in file-browser
<SHIFT> + <TOUCHPAD X> : control super knob of QuickEffectRack for deck 1 <SHIFT> + <TOUCHPAD Y> : control super knob of QuickEffectRack for deck 2
|
Now targeting 2.4. |
|
Those selective CI checks that fail in various circumstances by not covering all use cases are a real burden. A brute force enforcement once would have been much easier. |
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
Thank you for investing some time in the cleanup. Got one more modernization opportunity for you. the rest LGTM.
| // initialise decks | ||
| // Seb Dooris, Fayaaz Ahmed, Lee Arromba, Raphael Quast | ||
|
|
||
| // Using `const`/`let` causes ReferenceError: KAOSSDJ is not defined |
There was a problem hiding this comment.
We expect the "controller namespace" (KAOSSDJ in this case) to be accessible via the global object. That only happens when variable is declared via var in the global context. Declaring it using const or let won't do that. You can confirm this in node js using the following snippet:
const a = "a";
let b = "b";
var c = "c";
console.log(`a: ${a}, global.a: ${global.a}\nb: ${b}, global.b: ${global.b}\nc: ${c}, global.c: ${global.c}`);I'm not sure if we can access these variables without the global object, but we could try.
There was a problem hiding this comment.
Fix shouldn't be particularly difficult, I expect about 10-20 extra lines. Though I don't have time to look into this right now.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sorry to pitch in on this again. |
|
Unfortunately it looks like that Uwe dies not have interest to continue working on this mapping. A first step would be to issue a new pull request, test it and test it. Than we need to consider what us left for a merge to the 2.4 branch. |
6 participants
Continuation of #4301 which seems to be abandoned and is in a bad state.
I haven't touched the corresponding manual PR mixxxdj/manual#430 yet.