Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4

[HorstBaerbel]

Much improved and cleaned up version of PR #10892 by @gqzomer (Gersom Zomer) using Mixxx 2.4 functions like effect presets. Documentation in a new manual PR here #592.
Please consider this for inclusion in Mixxx 2.4. If you have improvements or need adjustments we're happy to improve the PR.

[ronso0]

@HorstBaerbel Did you alread sign the Mixxx Contributor Agreement?
If yes, which alias did you pick?

[ronso0]

I just made another attempt to review this. I only did a brief check, still no js expert.
Would appreciate some help by @JoergAtGithub or @Swiftb0y

[HorstBaerbel]

@HorstBaerbel Did you alread sign the Mixxx Contributor Agreement? If yes, which alias did you pick?

Signed as HorstBaerbel 👍

[gqzomer]

@ronso0 Is it enough for the owner of the pull request to sign the contributor agreement? Or should I also sign the agreement as a contributor to this mapping?

[ronso0]

This PR contains many commits of yours so it would be very welcome if sign it as well, thank you!

[gqzomer]

This PR contains many commits of yours so it would be very welcome if sign it as well, thank you!

Signed as gqzomer

[gqzomer]

The requested changes have been applied a while back. @ronso0 can you maybe resolve your request for changes so this pull request correctly reflects it is ready to be merged?

.

[ronso0]

Thanks @gqzomer for the reminder.
I dismissed my review (won't approve though since I'm still no js expert)

I'll leave some more notes.

[Swiftb0y]

I'm not a fan of this style of review anyways and since I don't have the controller I also can't really make any suggestion from a mapping user perspective. If this mapping leveraged ComponentsJS I could make better suggestions but I understand if thats too much to ask. I can make a bunch of code-style nitpicks but that wouldn't make it more readable either so I guess LGTM?

[daschuer]

Merge?

[gqzomer]

@Swiftb0y I have looked into ComponentsJS in the past for this controller. But as I understood it Component style mappings are mostly beneficial for controllers that use a different channel for each deck. Sadly this controller uses only one channel and opts for different midi inputs for the left and right deck. Either way the starting point for this pull request was a non-ComponentsJS mapping submitted in an earlier pull request by @HorstBaerbel

[Swiftb0y]

But as I understood it Component style mappings are mostly beneficial for controllers that use a different channel for each deck.

No that doesn't particularly matter. ComponentJS is useful for encapsulating state which applies to almost every mapping (this one included as you can see by the many global state-tracking variables at the top). Anyways, doesn't particularly matter now.

[daschuer]

@Swiftb0y merge?

[Swiftb0y]

waiting for @ronso0 to give his LGTM on the manual PR.

[ronso0]

Thanks to everyone involved!