Add FX Knob Script to "Korg Kaoss DJ" - #12807
Conversation
|
Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. |
Yes. please add them in this PR if you're interested in having them. |
I don't really know how and don't have the time to work on it extensively at the moment. Just left these suggestions there for later reference. As mentioned in the previous PR, it would be nice to get this merged to 2.4. I signed the agreement. |
Sure, if it doesn't make it into 2.4.0, it will go into 2.4.1 or whatever the next release will be then.
Yup. That would be great if you could take care of that. |
|
@daschuer a squash merge would be most appropriate here... |
|
I manually squashed your commits and merged them into the kaoss-dj PR. Thanks for your work. |
Based on #12683
The FX knob now functions as follows:
[no shift] Cycles QuickEffects of Channel 1 + 2
[left shift] Cycles chains on EffectUnit1
[right shift] Cycles chains on EffectUnit2
With this integrated I think the script is now in a state of merging.
I would still need to change the manual to reflect on this last change.
Some future improvements could be: