Skip to content

(fix) backport: require a minimum movement before initiating the drag&drop of tracks - #13135

Merged
m0dB merged 1 commit into
mixxxdj:2.4from
ronso0:stars-drag
Apr 20, 2024
Merged

(fix) backport: require a minimum movement before initiating the drag&drop of tracks#13135
m0dB merged 1 commit into
mixxxdj:2.4from
ronso0:stars-drag

Conversation

@ronso0

@ronso0 ronso0 commented Apr 19, 2024

Copy link
Copy Markdown
Member

#12903 for 2.4

Might already fix #13095
If not I'll try to refactor mouse move in StarEditor.

@ronso0
ronso0 marked this pull request as draft April 19, 2024 21:22
@github-actions github-actions Bot added the ui label Apr 19, 2024
@m0dB

m0dB commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

any reason for the draft status?

@ronso0

ronso0 commented Apr 20, 2024

Copy link
Copy Markdown
Member Author

Mhh, none actually, want to wait for CI and attempt the star delegate fix, but didn't find time.

@ronso0

ronso0 commented Apr 20, 2024

Copy link
Copy Markdown
Member Author

The star fix will be separate.
Feel free to merge!

@ronso0
ronso0 marked this pull request as ready for review April 20, 2024 13:30
@ronso0 ronso0 added this to the 2.4.1 milestone Apr 20, 2024
@m0dB
m0dB merged commit 052c81a into mixxxdj:2.4 Apr 20, 2024
@ronso0
ronso0 deleted the stars-drag branch April 20, 2024 17:08
@ronso0 ronso0 linked an issue Apr 21, 2024 that may be closed by this pull request
@ronso0

ronso0 commented Apr 21, 2024

Copy link
Copy Markdown
Member Author

Seems this fixed #13095 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot select star rating in list view

2 participants