Skip to content

(fixup) OpenGLWindow / waveform / spinnies: don't get keyboard focus on click - #13211

Merged
daschuer merged 1 commit into
mixxxdj:2.4from
ronso0:waveform-focus-block-flag
May 6, 2024
Merged

(fixup) OpenGLWindow / waveform / spinnies: don't get keyboard focus on click#13211
daschuer merged 1 commit into
mixxxdj:2.4from
ronso0:waveform-focus-block-flag

Conversation

@ronso0

@ronso0 ronso0 commented May 5, 2024

Copy link
Copy Markdown
Member

fixup for #13174 that also work with Qt6 (Qt 6.2.3 on Linux).

@m0dB Please take a look / test on macOS.

@github-actions github-actions Bot added the ui label May 5, 2024
@ronso0 ronso0 added this to the 2.4.1 milestone May 5, 2024
@ronso0 ronso0 changed the title OpenGLWindow / waveform / spinnies: don't get keyboard focus on click (fixup) OpenGLWindow / waveform / spinnies: don't get keyboard focus on click May 6, 2024
@daschuer

daschuer commented May 6, 2024

Copy link
Copy Markdown
Member

It looks like the flag is fixed for macOS in Qt 5.3
https://codereview.qt-project.org/c/qt/qtbase/+/88654

LGTM, thank you.

@daschuer
daschuer merged commit 83de7a5 into mixxxdj:2.4 May 6, 2024
@ronso0
ronso0 deleted the waveform-focus-block-flag branch May 6, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants