(fix) Pref Mixer: don't update EQs/QuickEffects while applying - #13333
Merged
Conversation
and simplify QuickEffect update if one has been changed in the skin or via controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed a bug in the Mixer preferences:
Reason was that the
effectChangedcallback resets the pref UI to the current engine state, i.e. wipes pending changes.Fixed with yet another bool flag.
I adopted this scheme for the similiar callback for QuickEffects and removed the extra slot (which didn't set
m_quickEffectIndiciesOnUpdateanyway, i.e. would needlessly reload the QuickEffect and potentially reset the Super knob).