Skip to content

fix: components.Pot producing wrong result on first value #13463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m0dB merged 1 commit into from
Jul 13, 2024
Merged

fix: components.Pot producing wrong result on first value #13463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions res/controllers/midi-components-0.0.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,7 @@
if (this.max === Component.prototype.max) {
this.max = (1 << 14) - 1;
}
value = (value << 7) + (this._firstLSB ? this._firstLSB : 0);
this.input(channel, control, value, status, group);
this.input(channel, control, (value << 7) + (this._firstLSB ? this._firstLSB : 0), status, group);
}
this.MSB = value;
Comment on lines 484 to 486

@Swiftb0y Swiftb0y Jul 11, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick word on the fix:
This only occurred when receiving the first value because this branch is only executed when receiving the first value. this.MSB is only supposed to contain the value of the most significant byte, but the branch erroneously set it contain the entire value. That meant if the MSB was received first everything would work out for the first message, however, when the LSB was received afterwards it would take the bogus MSB value set here resulting in huge bogus values. Once the second MSB was received, everything would work out as usual again. The fix now ensures that this.MSB gets the actual MSB value instead of the "pre-scaled" one that we use in the branch.

@m0dB m0dB Jul 13, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
Expand Down