Fix detection last sound if track does not end with silence. - #13545
Merged
Conversation
This can be fixed by deleting the outro cue points and reload the track into a deck. Fixes mixxxdj#13449
Swiftb0y
approved these changes
Aug 8, 2024
Swiftb0y
left a comment
Swiftb0y
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for investigating. This may have been spotted earlier if we properly encoded the "no silence found" state in the typesystem (std::optional<SINT> maybe).
Closed
davidlmorris
added a commit
to davidlmorris/mixxx
that referenced
this pull request
Oct 19, 2024
Adjust lasttSampleBeforeFadeOut (and avoid a regression with lastSoundSample) to bring it into line with mixxxdj#13545 (I assume I was working off an older code base.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be fixed by deleting the outro cue points and reload the track into a deck. Fixes #13449