(fix/UX) Track menu: Left key in Search related & Crates menus closes them again by ronso0 · Pull Request #13602 · mixxxdj/mixxx

ronso0 · 2024-08-26T14:35:14Z

If a QWidgetAction in either Search related & Crates menu is focused, Left/Right keys are translated to Up/Down which prevents closing the submenus with Left key like in other submenus.
(in the Crates menu left works as soon as the New Crate button is reached)

Fix:

~~Translate Left to Esc to close this submenu.~~
Call hide() of the respective sumenu.

For fixing the crates menu this should actually go to 2.4 ("Search related Tracks" has QWidgetActions only in 2.5), but since we're going to release that shortly before 2.5 I think it's okay to merge the double fix to 2.5-beta

cr7pt0gr4ph7

LGTM. The issue fixed by this is still present in main, so maybe merge it to main if it should already be too late for 2.5.

…u (PR mixxxdj#13602)

JoergAtGithub · 2024-12-15T14:25:00Z

I tried this and it crashed with:
Exception thrown: read access violation. this->d_ptr.**d** was 0x10001004A.

 	Qt6Core.dll!QObject::parent() Line 376	C++
>	[Inline Frame] mixxx.exe!parented_ptr<QWidgetAction>::{dtor}() Line 37	C++
 	[Inline Frame] mixxx.exe!parented_ptr<QWidgetAction>::operator=(parented_ptr<QWidgetAction> &&) Line 65	C++
 	mixxx.exe!WSearchRelatedTracksMenu::addActionsForTrack(const Track & track={...}) Line 364	C++
 	[Inline Frame] mixxx.exe!WTrackMenu::createMenus::__l29::<lambda_1>::operator()() Line 255	C++
 	[Inline Frame] mixxx.exe!QtPrivate::FunctorCall<QtPrivate::IndexesList<>,QtPrivate::List<>,void,`WTrackMenu::createMenus'::`29'::<lambda_1>>::call(WTrackMenu::createMenus::__l29::<lambda_1> &) Line 129	C++
 	[Inline Frame] mixxx.exe!QtPrivate::Functor<`WTrackMenu::createMenus'::`29'::<lambda_1>,0>::call(WTrackMenu::createMenus::__l29::<lambda_1> &) Line 243	C++
 	mixxx.exe!QtPrivate::QFunctorSlotObject<`WTrackMenu::createMenus'::`29'::<lambda_1>,0,QtPrivate::List<>,void>::impl(int which, QtPrivate::QSlotObjectBase * this_=0x000001fd0829df70, QObject * r=0x000000516c6fb500, void * * a=0x00007ffed961946d, bool * ret=0x0000000000000000) Line 457	C++
 	[Inline Frame] Qt6Core.dll!QtPrivate::QSlotObjectBase::call(QObject *) Line 374	C++
 	Qt6Core.dll!doActivate<0>(QObject * sender=0x000001fd13bd6420, int signal_index=7, void * * argv) Line 4036	C++
 	Qt6Core.dll!QMetaObject::activate(QObject * sender=0x000001fd13bd6420, const QMetaObject * m, int local_signal_index=0, void * * argv=0x0000000000000000) Line 4097	C++
 	[Inline Frame] Qt6Widgets.dll!QMenu::aboutToShow() Line 352	C++
 	Qt6Widgets.dll!QMenuPrivate::popup(const QPoint & p={...}, QAction * atAction=0x0000000000000000, std::function<QPoint __cdecl(QSize const &)> positionFunction={...}) Line 2369	C++
 	[Inline Frame] Qt6Widgets.dll!QMenu::popup(const QPoint &) Line 2306	C++
 	Qt6Widgets.dll!QMenu::internalDelayedPopup() Line 3627	C++
 	[Inline Frame] Qt6Widgets.dll!QEvent::accept() Line 303	C++
 	Qt6Widgets.dll!QMenu::keyPressEvent(QKeyEvent * e=0x000000516c6fc6e0) Line 3418	C++
 	Qt6Widgets.dll!QWidget::event(QEvent * event=0x000000516c6fc6e0) Line 9005	C++
 	Qt6Widgets.dll!QMenu::event(QEvent * e=0x000000516c6fc6e0) Line 3047	C++
 	Qt6Widgets.dll!QApplicationPrivate::notify_helper(QObject * receiver=0x000001fd07da7700, QEvent * e=0x000000516c6fc6e0) Line 3292	C++
 	Qt6Widgets.dll!QApplication::notify(QObject * receiver=0x000001fd07da7700, QEvent * e=0x000000516c6fc6e0) Line 2718	C++
 	Qt6Core.dll!QCoreApplication::notifyInternal2(QObject * receiver=0x000001fd07da7700, QEvent * event=0x000000516c6fc6e0) Line 1118	C++
 	Qt6Widgets.dll!QWidgetWindow::event(QEvent * event=0x000000516c6fc6e0) Line 313	C++
 	Qt6Widgets.dll!QApplicationPrivate::notify_helper(QObject * receiver=0x000001fd35e643f0, QEvent * e=0x000000516c6fc6e0) Line 3292	C++
 	Qt6Widgets.dll!QApplication::notify(QObject * receiver=0x000001fd35e643f0, QEvent * e=0x000000516c6fc6e0) Line 3244	C++
 	Qt6Core.dll!QCoreApplication::notifyInternal2(QObject * receiver=0x000001fd35e643f0, QEvent * event=0x000000516c6fc6e0) Line 1118	C++
 	Qt6Gui.dll!QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent * e=0x000001fd15e06ce0) Line 2459	C++
 	Qt6Gui.dll!QWindowSystemInterface::sendWindowSystemEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 1100	C++
 	Qt6Core.dll!QEventDispatcherWin32::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 464	C++
 	Qt6Gui.dll!QWindowsGuiEventDispatcher::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags) Line 37	C++
 	[Inline Frame] Qt6Core.dll!QEventLoop::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag>) Line 100	C++
 	Qt6Core.dll!QEventLoop::exec(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 182	C++
 	Qt6Core.dll!QCoreApplication::exec() Line 1439	C++
 	mixxx.exe!`anonymous namespace'::runMixxx(MixxxApplication * pApp=0x000000516c6ffc48, const CmdlineArgs & args={...}) Line 108	C++
 	mixxx.exe!main(int argc=1, char * * argv=0x000001fd36dfc1b0) Line 243	C++
 	[Inline Frame] mixxx.exe!invoke_main() Line 78	C++
 	mixxx.exe!__scrt_common_main_seh() Line 288	C++
 	kernel32.dll!BaseThreadInitThunk()	Unknown
 	ntdll.dll!RtlUserThreadStart()	
```Unknown

For consistency, I would also filter the Right key.

daschuer · 2025-01-19T23:01:49Z

@JoergAtGithub I can't reproduce the crasher. It looks like a dangling pointer access. Unfortunately I cannot reproduce the issue.
Do you have receipt for it?

acolombier

friendly ping @JoergAtGithub - are you able to provide reproduction steps for this bug?

ronso0 · 2025-02-22T04:31:14Z

I extended that to ignore Right key as suggested by @JoergAtGithub

JoergAtGithub · 2025-06-19T08:29:19Z

I just tested 7ca7aea on Windows and it still crashes sporadic with a read access violation:

Exception thrown: read access violation.
this->d_ptr.**d** was nullptr.

The stacktrace below was from an exception after pressing the right arrow button to open the search menu, which I closed immediately before with the left arrow button:

	Qt6Core.dll!QObject::parent() Line 376	C++
 	[Inline Frame] mixxx.exe!parented_ptr<QWidgetAction>::{dtor}() Line 37	C++
 	[Inline Frame] mixxx.exe!parented_ptr<QWidgetAction>::operator=(parented_ptr<QWidgetAction> &&) Line 65	C++
 	mixxx.exe!WSearchRelatedTracksMenu::addActionsForTrack(const Track & track={...}) Line 364	C++
 	[Inline Frame] mixxx.exe!WTrackMenu::createMenus::__l29::<lambda_1>::operator()() Line 259	C++
 	[Inline Frame] mixxx.exe!QtPrivate::FunctorCall<QtPrivate::IndexesList<>,QtPrivate::List<>,void,`WTrackMenu::createMenus'::`29'::<lambda_1>>::call(WTrackMenu::createMenus::__l29::<lambda_1> &) Line 129	C++
 	[Inline Frame] mixxx.exe!QtPrivate::Functor<`WTrackMenu::createMenus'::`29'::<lambda_1>,0>::call(WTrackMenu::createMenus::__l29::<lambda_1> &) Line 243	C++
 	mixxx.exe!QtPrivate::QFunctorSlotObject<`WTrackMenu::createMenus'::`29'::<lambda_1>,0,QtPrivate::List<>,void>::impl(int which, QtPrivate::QSlotObjectBase * this_=0x000002073aa39820, QObject * r=0x00000015688fb350, void * * a=0x00007ff80819946d, bool * ret=0x0000000000000000) Line 457	C++
 	[Inline Frame] Qt6Core.dll!QtPrivate::QSlotObjectBase::call(QObject *) Line 374	C++
 	Qt6Core.dll!doActivate<0>(QObject * sender=0x000002077b5c9580, int signal_index=0x00000007, void * * argv) Line 4036	C++
 	Qt6Core.dll!QMetaObject::activate(QObject * sender=0x000002077b5c9580, const QMetaObject * m, int local_signal_index=0x00000000, void * * argv=0x0000000000000000) Line 4097	C++
 	[Inline Frame] Qt6Widgets.dll!QMenu::aboutToShow() Line 352	C++
 	Qt6Widgets.dll!QMenuPrivate::popup(const QPoint & p={...}, QAction * atAction=0x0000000000000000, std::function<QPoint __cdecl(QSize const &)> positionFunction={...}) Line 2369	C++
 	[Inline Frame] Qt6Widgets.dll!QMenu::popup(const QPoint &) Line 2306	C++
 	Qt6Widgets.dll!QMenu::internalDelayedPopup() Line 3627	C++
 	[Inline Frame] Qt6Widgets.dll!QEvent::accept() Line 303	C++
 	Qt6Widgets.dll!QMenu::keyPressEvent(QKeyEvent * e=0x00000015688fc530) Line 3418	C++
 	Qt6Widgets.dll!QWidget::event(QEvent * event=0x00000015688fc530) Line 9005	C++
 	Qt6Widgets.dll!QMenu::event(QEvent * e=0x00000015688fc530) Line 3047	C++
 	Qt6Widgets.dll!QApplicationPrivate::notify_helper(QObject * receiver=0x000002076cbb5740, QEvent * e=0x00000015688fc530) Line 3292	C++
 	Qt6Widgets.dll!QApplication::notify(QObject * receiver=0x000002076cbb5740, QEvent * e=0x00000015688fc530) Line 2718	C++
 	Qt6Core.dll!QCoreApplication::notifyInternal2(QObject * receiver=0x000002076cbb5740, QEvent * event=0x00000015688fc530) Line 1118	C++
 	Qt6Widgets.dll!QWidgetWindow::event(QEvent * event=0x00000015688fc530) Line 313	C++
 	Qt6Widgets.dll!QApplicationPrivate::notify_helper(QObject * receiver=0x00000207113ec0d0, QEvent * e=0x00000015688fc530) Line 3292	C++
 	Qt6Widgets.dll!QApplication::notify(QObject * receiver=0x00000207113ec0d0, QEvent * e=0x00000015688fc530) Line 3244	C++
 	Qt6Core.dll!QCoreApplication::notifyInternal2(QObject * receiver=0x00000207113ec0d0, QEvent * event=0x00000015688fc530) Line 1118	C++
 	Qt6Gui.dll!QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent * e=0x000002071125e350) Line 2459	C++
 	Qt6Gui.dll!QWindowSystemInterface::sendWindowSystemEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 1100	C++
 	Qt6Core.dll!QEventDispatcherWin32::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 464	C++
 	Qt6Gui.dll!QWindowsGuiEventDispatcher::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag> flags) Line 37	C++
 	[Inline Frame] Qt6Core.dll!QEventLoop::processEvents(QFlags<enum QEventLoop::ProcessEventsFlag>) Line 100	C++
 	Qt6Core.dll!QEventLoop::exec(QFlags<enum QEventLoop::ProcessEventsFlag> flags={...}) Line 182	C++
 	Qt6Core.dll!QCoreApplication::exec() Line 1439	C++
 	mixxx.exe!`anonymous namespace'::runMixxx(MixxxApplication * pApp=0x00000015688ffaa0, const CmdlineArgs & args={...}) Line 108	C++
 	mixxx.exe!main(int argc=0x00000001, char * * argv=0x000002071eb37070) Line 243	C++

ronso0 · 2025-11-13T10:11:29Z

@JoergAtGithub Do you use the Search Related menu currently?
If yes, do you experience crashes when you leave that menu to auto-close it (hover main track menu)?

ronso0 · 2025-11-13T11:15:31Z

I have reworked the creation of Search Related so it's not cleared on every aboutToShow event.
= identical to Crates menu
And I added an assertion for action->parent()

Hopefully that fixes the crasher.

daschuer · 2026-03-29T18:56:27Z

Is this still in draft state?

ronso0 · 2026-03-30T11:32:44Z

It's ready for review.
I decided to leave it as draft until we figure the cause of the the crash Jörg experienced, but I still don't see how that is related to these changes.

ronso0 · 2026-06-15T22:45:49Z

@JoergAtGithub I think the crash you saw #13602 (comment) is #15197, hence unrelated to this PR

daschuer · 2026-08-02T20:06:08Z

Conflict have developed.

…Actions

ronso0 · 2026-08-02T23:50:26Z

I rebased now that #16697 has been merged

daschuer · 2026-08-03T05:25:48Z

@JoergAtGithub can this be merged now?

github-actions Bot added the ui label Aug 26, 2024

ronso0 added this to the 2.5.0 milestone Sep 6, 2024

ronso0 force-pushed the trackmenu-left-close-submenu branch from bba8f41 to 693c17e Compare September 9, 2024 22:17

ronso0 changed the title ~~(fix/UX) Track menu: translate Left key to Esc in Search related & Crates menus~~ (fix/UX) Track menu: Left key in Search related & Crates menus closes them again Sep 10, 2024

ronso0 added the usability label Sep 10, 2024

cr7pt0gr4ph7 approved these changes Oct 31, 2024

View reviewed changes

cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/mixxx that referenced this pull request Oct 31, 2024

[Staging] Add external branch rons0/mixxx:trackmenu-left-close-submen…

a8fcbf6

…u (PR mixxxdj#13602)

JoergAtGithub removed this from the 2.5.0 milestone Dec 15, 2024

daschuer mentioned this pull request Jan 19, 2025

Fix memory leak and use parented_ptr in WTrackMenu #14199

Merged

acolombier reviewed Feb 18, 2025

View reviewed changes

Comment thread src/widget/wtrackmenu.cpp Outdated

daschuer requested a review from JoergAtGithub April 25, 2025 06:36

daschuer force-pushed the 2.5 branch from d0d7738 to 0e2e43d Compare April 27, 2025 01:24

ronso0 force-pushed the trackmenu-left-close-submenu branch from 6ce08a7 to 7ca7aea Compare June 6, 2025 23:17

ronso0 added this to the 2.5.2 milestone Jun 7, 2025

daschuer modified the milestones: 2.5.2, 2.5.3 Jun 13, 2025

acolombier force-pushed the 2.5 branch 2 times, most recently from cd725b1 to d7d5934 Compare June 20, 2025 18:01

ronso0 mentioned this pull request Aug 14, 2025

Segfault: DEBUG_ASSERT(!m_ptr || static_cast<const QObject*>(m_ptr)->pt()); #15197

Open

JoergAtGithub modified the milestones: 2.5.3, 2.5.4 Aug 24, 2025

ronso0 force-pushed the trackmenu-left-close-submenu branch from 7ca7aea to 7b971e8 Compare November 13, 2025 10:58

ronso0 marked this pull request as draft November 13, 2025 11:03

ronso0 force-pushed the trackmenu-left-close-submenu branch from 7b971e8 to 63ff487 Compare November 13, 2025 11:16

ronso0 force-pushed the trackmenu-left-close-submenu branch from 63ff487 to 39a5996 Compare November 13, 2025 13:24

ronso0 modified the milestones: 2.5.4, 2.6.0 Dec 9, 2025

acolombier changed the base branch from 2.5 to 2.6 March 13, 2026 16:33

ronso0 marked this pull request as ready for review March 30, 2026 11:31

ronso0 modified the milestones: 2.6.0, 2.6.1 May 22, 2026

Track Menu: close all menus with Left key, fix for menus with QWidget…

0706518

…Actions

ronso0 force-pushed the trackmenu-left-close-submenu branch from 39a5996 to 0706518 Compare August 2, 2026 23:49

Uh oh!

Uh oh!

Conversation

ronso0 commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix:

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub commented Dec 15, 2024

Uh oh!

daschuer commented Jan 19, 2025

Uh oh!

acolombier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ronso0 commented Feb 22, 2025

Uh oh!

JoergAtGithub commented Jun 19, 2025

Uh oh!

ronso0 commented Nov 13, 2025

Uh oh!

ronso0 commented Nov 13, 2025

Uh oh!

daschuer commented Mar 29, 2026

Uh oh!

ronso0 commented Mar 30, 2026

Uh oh!

ronso0 commented Jun 15, 2026

Uh oh!

daschuer commented Aug 2, 2026

Uh oh!

ronso0 commented Aug 2, 2026

Uh oh!

daschuer commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ronso0 commented Aug 26, 2024 •

edited

Loading