(fix) Controller engine: unify/improve logging, expand error dialog's Details box - #13626
Merged
Merged
Conversation
Swiftb0y
approved these changes
Sep 4, 2024
Swiftb0y
left a comment
Swiftb0y
left a comment
Member
There was a problem hiding this comment.
Didn't do any testing, but code changes LGTM.
Member
|
Tested. still LGTM. @ronso0 do you want to remove the test commit? then I'll merge. |
ronso0
force-pushed
the
js-error-dialog-more-details
branch
from
September 11, 2024 09:30
d5e4daa to
79c5708
Compare
Member
Author
|
TEST removed, ready to roll. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the
m_detailsUseMonospaceFontflag to expand that box for mapping errors.I multiplied the invalid mappings in the Numark Total Control mapping, load that to MIDI Through Port for easy testing.
Note:
In case you run into the selectionModel()/model() DEBUG_ASSERT during startup (see #13620 / #13623) you should cherry-pick 1a61e0f (or build with DEBUG_ASSERTIONS_FATAL set OFF)