Skip to content

Update FindFFTW3.cmake to not find version 2 and use PkgConfig - #13937

Merged
Holzhaus merged 1 commit into
mixxxdj:2.5from
daschuer:gh13931
Jan 26, 2025
Merged

Update FindFFTW3.cmake to not find version 2 and use PkgConfig#13937
Holzhaus merged 1 commit into
mixxxdj:2.5from
daschuer:gh13931

Conversation

@daschuer

@daschuer daschuer commented Nov 26, 2024

Copy link
Copy Markdown
Member

This fixes #13931 , th acase if FFTW version 2 and 3 is installed on the build system.

This can be a last minute 2.4.2 fix

@daschuer

Copy link
Copy Markdown
Member Author

@Holzhaus can you have a look? And also to mixxxdj/libkeyfinder#34 Thank you.

@daschuer daschuer modified the milestones: 2.4.2, 2.5.0 Nov 26, 2024
@JoergAtGithub

Copy link
Copy Markdown
Member

@Holzhaus I consider the risk for the 2.5 release low here, as CI passes. What do you think?

@daschuer daschuer modified the milestones: 2.5.0, 2.5.1 Dec 24, 2024
@daschuer
daschuer changed the base branch from 2.4 to 2.5 January 25, 2025 22:03
@daschuer

Copy link
Copy Markdown
Member Author

Rebased, and ready for merge.

@Holzhaus

Copy link
Copy Markdown
Member

Oh sorry, I didn't notice it in my notifications.

@Holzhaus
Holzhaus merged commit 2b9024f into mixxxdj:2.5 Jan 26, 2025
@daschuer
daschuer deleted the gh13931 branch April 24, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants