show effect knob parameter value when clicking knob #14638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
effect-param-knob-click-currvalue
branch
from
cc96e9c to
521cbf5
Compare
ronso0
force-pushed
the
effect-param-knob-click-currvalue
branch
from
521cbf5 to
f766b71
Compare
ronso0
commented
Apr 15, 2025
| // We set a flag in order to not show the value in that case. | ||
| // Though only suppress it for those knobs! For unlinked knobs it would | ||
| // prevent showing the value on first click. | ||
| EffectKnobParameterSlot* paramKnob = |
Member
Author
There was a problem hiding this comment.
Btw this independent from the Meta knob keep/reset setting, ie. now works as expected in all situations.
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Member
Author
|
I rarely need this, but it has proven helpful, for example to verify a parameter is 1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14374
Click the knob to show the parameter value in the parameter name label, like when turning the knob.
Enabled by constructing the parameter CO with
ignoreNoOps= false and re-setting the current value on click.This is still sort of a hack, but it's a minimal invasive and robust solution, compared to trying to connect the knob and label widgets as proposed in #14596.
We could also re-apply the current value in a new
ControlParameterWidgetConnectionfunction (get parameter, set parameter), but it makes no difference, except that we have more code to maintain. The test commit is d217c2eedit Oh, looks like this is still missing the fix to make it work on first click after changing the effect or swapping parameters (ie. after skin load). Will amend that soonish.