Improve debug output in case of failing soundsource test - #14658
Open
daschuer wants to merge 3 commits into
Open
Improve debug output in case of failing soundsource test#14658daschuer wants to merge 3 commits into
daschuer wants to merge 3 commits into
Conversation
acolombier
force-pushed
the
2.5
branch
2 times, most recently
from
June 20, 2025 18:01
cd725b1 to
d7d5934
Compare
Now with the samples in csv format.
daschuer
force-pushed
the
cvs_soundsource_test
branch
from
February 7, 2026 11:58
0a94861 to
a8edc17
Compare
Member
Author
|
Rebased to 2.5 |
|
Not sure if the above error_count off-by-one is intentional. Apart from that this looks good to me |
Member
Author
|
Is an inline comment missing? To publish pending review comments you need to finish it with a result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a never ending list of Google Test failures, this outputs only the first issue per challenge and than gives a brief statistics about the rest of the buffer plus all samples in csv format.
This is hopefully the right tool to decide about decoder seek qualities.
The visualization can than look like this using LibreOffice: