add WCuebutton: drag onto play button to latch play / + fix: revert to 36 hotcues - #14753
Conversation
this allows replacing the massive include cuecontrol.h where only the max hotcue number is needed
github-actions
Bot
added
skins
engine
ui
build
preferences
waveform
controller backend
labels
d94f7d0 to
e9d25ba
Compare
|
Yes, as it's closely related to dropping hotcues on the playbutton, |
e9d25ba to
b3b5d29
Compare
b3b5d29 to
f816012
Compare
| constexpr unsigned int MAX_BUFFER_LEN = 160000; | ||
|
|
||
| constexpr int kMaxNumberOfDecks = 4; | ||
| constexpr int kMaxNumberOfHotcues = 37; |
There was a problem hiding this comment.
Btw why is this 37?
Some dev was bored of even numbers and 2^n and picked a prime number to make it a bit more exciting 🤣
There was a problem hiding this comment.
This is for https://github.com/mixxxdj/mixxx/wiki/Stanton-Scs.3D#trig-modes
There must have happen a one-off isseue somewhere that we have 37 and not 36 = 3 x 12
622ed83
There was a problem hiding this comment.
Okay, thanks for digging.
Shall we revert that to 36?
I know this would be considered a 'breaking change', but I wonder who is really using 37 hotcues?
There was a problem hiding this comment.
Alright. Can do this when this PR gets a LGTM
Since it completes (fixes) the cue button sorting feature so I tend to agree. Can you add a CHANGELOG entry to this PR to reduce maintenance. I have also tried to make the main CUE a hot cue, by dropping. I have no use case for this though. |
|
Thank you. |
ronso0
changed the title
playplay / + fix: revert to 36 hotcues
3 participants
(late) follow-up for #14179
Like WHotcueButton, it can be dragged onto WPlayButton to switch from cue previewing to regular (latched) play.
Mostly c/p from WHotcueButton + adjusted
hotcuedraghelpers and callers.edit also reverts to 36 hotcues #14753 (comment)
IMHO this can slip into 2.6-beta after release, wdyt?
TODO