Skip to content

Conversation

@ronso0
Copy link
Member

@ronso0 ronso0 commented Sep 22, 2025

Closes #13748

There's a dialog that let's you select which of the duplicates you want to keep:
image

@ronso0 ronso0 force-pushed the playlist-remove-duplicates branch from db072ca to 1493df0 Compare September 23, 2025 09:43
@ronso0 ronso0 added this to the 2.7-beta milestone Sep 24, 2025
@ronso0 ronso0 force-pushed the playlist-remove-duplicates branch from 1493df0 to 0830c57 Compare October 11, 2025 01:18
@ronso0 ronso0 force-pushed the playlist-remove-duplicates branch from 0830c57 to d3b27f5 Compare October 11, 2025 01:20
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 10, 2026
QDialog dlgSelectTracksToKeep;
dlgSelectTracksToKeep.setWindowTitle(tr("Remove Duplicate Tracks"));
auto pDescriptionLabel = make_parented<QLabel>(
tr("Select which of each duplicate track you want to keep."),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tr("Select which of each duplicate track you want to keep."),
tr("Select which duplicate tracks you want to keep."),

Comment on lines +337 to +343
tr("First position"), &dlgSelectTracksToKeep);
auto pLastPosButton = make_parented<QRadioButton>(
tr("Last position"), &dlgSelectTracksToKeep);
auto pFirstAddedButton = make_parented<QRadioButton>(
tr("First added"), &dlgSelectTracksToKeep);
auto pLastAddedButton = make_parented<QRadioButton>(
tr("Last added"), &dlgSelectTracksToKeep);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tr("First position"), &dlgSelectTracksToKeep);
auto pLastPosButton = make_parented<QRadioButton>(
tr("Last position"), &dlgSelectTracksToKeep);
auto pFirstAddedButton = make_parented<QRadioButton>(
tr("First added"), &dlgSelectTracksToKeep);
auto pLastAddedButton = make_parented<QRadioButton>(
tr("Last added"), &dlgSelectTracksToKeep);
tr("Keep first position"), &dlgSelectTracksToKeep);
auto pLastPosButton = make_parented<QRadioButton>(
tr("Keep last position"), &dlgSelectTracksToKeep);
auto pFirstAddedButton = make_parented<QRadioButton>(
tr("Keep first added"), &dlgSelectTracksToKeep);
auto pLastAddedButton = make_parented<QRadioButton>(
tr("Keep last added"), &dlgSelectTracksToKeep);


auto pButtons = make_parented<QDialogButtonBox>(&dlgSelectTracksToKeep);
QPushButton* pCancelBtn = pButtons->addButton(tr("Cancel"), QDialogButtonBox::RejectRole);
QPushButton* pOkayBtn = pButtons->addButton(tr("Okay"), QDialogButtonBox::AcceptRole);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QPushButton* pOkayBtn = pButtons->addButton(tr("Okay"), QDialogButtonBox::AcceptRole);
QPushButton* pOkayBtn = pButtons->addButton(tr("Continue"), QDialogButtonBox::AcceptRole);

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Remove duplicate tracks in playlists" function

1 participant