Pioneer DDJ-200: fix for hotcue issues, rewrite

[absorb-it]

The current implementation for this controller has some issues with the hotcue buttons not working as expected.

This is a rewrite of this controller implementation which fixes these issues. Beside all standard features some special things have been taken over from the already existing DDJ-200 script or added:

• 4 Deck control possible
• Select and load tracks from within the controller
• use pad buttons for
  • hotcues (ok, standard)
  • loops
  • effects and samples
  • beatjump

See

• https://github.com/absorb-it/Pioneer-DDJ-200-Mixxx
• https://mixxx.discourse.group/t/new-mapping-for-pioneer-ddj-200/31164/4
• https://mixxx.discourse.group/t/pioneer-ddj-200-mapping/18259/19

[absorb-it]

related documentation update at mixxxdj/manual#796

[JoergAtGithub]

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

[absorb-it]

Hi,

As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so.

read, understood and signed.

Regards, Rene

[JoergAtGithub]

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking
Than it will fix these issues automatically before every commit.
Alternatively, you can download the pre-commit.patch file from the artifacts of this PR

unzip it, and apply it using:
git apply pre-commit.patch

[JoergAtGithub]

I just noticed, that you set the main branch as target, but controller mapping changes shoul go into the stable 2.5 branch. Can you please change the target an rebase in Git.

[Swiftb0y]

Hey there Rene, I appreciate the rewrite with ComponentJS, The resulting implementation is much better than the previous one. However, there is still lots I would like to improve via code review. Would you be okay with spending some additional time getting this into an even better shape?

[absorb-it]

Hi @Swiftb0y

Would you be okay with spending some additional time getting this into an even better shape?

definitely. Looking forward to you suggestions.

[Swiftb0y]

Great. Will file a review shortly.

[Swiftb0y]

This should be plenty of feedback already. I will do my best to help you resolve them along the way.

[absorb-it]

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system

Fixed this by adding some exception to eslint.

Already used pre-commit, but this changed the code into non-working. Therefore commited the patch according to https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking just by using the SKIP environment variable on the command line. Finally found some solution which will survive pre-commit check and suggested some wiki- change in #15405

Regards, Rene

[absorb-it]

Hi, sorry for some mess I did trough the github interface, I tried to keep this PR based on 2.6 and synced with main branch instead - had to do a hard reset / force push to get rid of this again. But the github-actions bot was faster and added all possible labels to this PR. Seems like I can't remove them, sorry to anybody who has to clean this. Regards, Rene