Waveform preferences: optimize / cleanup #15421
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'll rebase / take care of the conflicts once #15349 has landed in main. |
ronso0
force-pushed
the
waveform-pref-opti-cleanup
branch
from
8bce4c7 to
7a2e1ff
Compare
Member
Author
|
Rebased and cleaned up. |
ninomp
reviewed
Oct 3, 2025
Contributor
ninomp
left a comment
ninomp
left a comment
There was a problem hiding this comment.
The code looks good, except one thing which I left a comment. I'll let you know when I test this.
| updateWaveformTypeOptions(true, | ||
| defaultBackend, | ||
| WaveformRendererSignalBase::Option::None); | ||
| //<<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Are these git conflict markers left intentionally or is this a mistake?
Member
Author
There was a problem hiding this comment.
Ha, I knew I'll forget to remove it when I get distracted..
Fixed.
Thanks for taking a look!
ronso0
force-pushed
the
waveform-pref-opti-cleanup
branch
from
7a2e1ff to
f7e509a
Compare
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
Member
Author
|
Great, thanks! |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15349 (2.6)
This is an attempt to make
DlgPrefWaveformeasier to maintain, essentially making it the frontend forWaveformWidgetFactoryby moving most get/set functions to the factory.