restore last selected library feature/playlist/crate on restart by mxmilkiib · Pull Request #15460 · mixxxdj/mixxx

mxmilkiib · 2025-10-08T04:41:19Z

implements #10125

persists the currently selected sidebar item (feature or child) to user settings and restores it on next mixxx startup.

uses feature title + child data for robust matching across sessions. gracefully falls back to default selection if saved item not found.

config keys:

[Library] LastSelectedFeature: stores feature title
[Library] LastSelectedChild: stores child item data (playlist/crate id)

daschuer

Thank you for this nice feature.

ronso0 · 2025-10-08T07:55:01Z

Why not simply store the number of the selected row + childrow?
The config value is not ment to be readable anyway.
And it would save us the TreeItem inspection.

[Library]
LastSelectedFeature 2-3

would be the 4th Playlist item.

ronso0 · 2025-10-08T07:59:33Z

+                            QModelIndex found = findChild(childIndex);
+                            if (found.isValid()) {
+                                return found;
+                            }


No need to iterate over children manually, just use pChildModel::match() and stop at first match.

I'd still prefer the row+childrow approach btw.

Note: both name- and index-based lookup will fail for Computer as the tree is created on demand / on expand.
For History it may fail if auto-cleanup deleted the selected playlist.

mxmilkiib · 2025-10-08T10:30:07Z

it can be changed if you think it would be less brittle for all/most cases

ronso0 · 2025-10-08T10:44:14Z

Well, there's no way to make it work for Computer and obviously auto-removed History items can't be selected.
So, while I'd prefer the index approach (saving is much simpler IMO), the name approach is okay IMHO if we want to make it work 100% also for history. In that case, please check the match method I mentioned as that would reduce code siginificantly afaict.

ronso0 · 2025-10-08T10:44:25Z

+                    pFeature->activateChild(savedIndex);
+                }
+            }
+        }


Why not use SidebarModel::clicked(index)?
Looks it does the exact same thing.

ronso0 · 2025-10-08T10:44:56Z

I'm curious, did you use ai to code this?

mxmilkiib · 2025-10-08T15:35:39Z

my preference would be for it to have that wider scope but with the graceful fallback/degradation

thanks, I'll check/use the suggestions later

yes, I used Claude Sonnet 4.5 thinking

it feels like Claude 4+, and GPT-5, are half-way around turning the not-slop corner. afaiu, this relates to the context window embiggening

(Windsurf currently has reduced rates for both, which is one facet of the bubble right now tbqf. I can't afford pro-level-spec-taking project-building Claude Opus)

quality depending on the correct promoting and process used; for recent context, the two big polarised HN stories about curl & AI (and stories like this and related comments)

(this aside from the relatively complex proof-is-in-the-pudding LPP3 script I've put together, lots of time being mindful of code smells, 8100+ LOC that I'll eventually modularise)

I'm thinking of getting together a RULES txt file guide for working with Mixxx, to collate patterns and preferences from the project (beyond just pointing to the wiki, which I forgot last night)

it's also helping me greatly with git and feature-branch/PR management all

(plus I've also recently finally massively refactored many dotconfigs, including making several AwesomeWM Lua modules)

ronso0 · 2025-10-18T12:05:51Z

+    QString featureIconName;
+    QString childData;


Suggested change

QString featureIconName;

QString childData;

QString featureName;

QString childName;

ronso0 · 2025-10-18T13:37:01Z

This is currently failing because the value QAbstractItemModel::match() is looking for is a QString (from config), but the model's data may either be int (playlist or crate id) or a QString (Computer -> Quick Links -> path).
Converting the config string might work, but we may also have item data consisting of int which are actually strings.
I think we need to first figure which data type the child model uses (query first child) and convert to that.

ronso0 · 2025-10-18T14:18:15Z

Besides, we need to use TreeItemModel::kDataRole for match().

Here's a fixup 6582dc2
(incl. reduced nesting, type check etc.)

Tested with playlists and Quick Links items.

mxmilkiib · 2025-10-20T02:44:48Z

it now stores the positioning of the sidebar view after each change

so, instead of trying to have the selected entry be bottom-most or centre, it just restores where the user had the scroll position beforehand

I think the requests were folded in properly

any other failure modes I should add protection for?

ronso0 · 2025-10-21T09:25:05Z

    // this event.
    stopPressedUntilClickedTimer();
    if (index.isValid()) {
+        // save the selection for restoration on restart


I think we need to store the selection only on shutdown, ie. in the destructor, not on every click?

ronso0 · 2025-10-21T09:32:21Z

+    connect(verticalScrollBar(),
+            &QScrollBar::valueChanged,
+            this,
+            &WLibrarySidebar::saveScrollPosition);


Let's not write to config for every scroll.

And not remove comments unless there's a real reason.

ronso0 · 2025-10-21T09:33:35Z

+    if (rowCount() == 0) {
+        return;
+    }
+


why do we need this?

does this prevent repainting a child model if we for example removed all History playlists?

ronso0 · 2025-10-21T09:34:34Z

-    // Start a timer to auto-expand sections the user hovers on.
+void WLibrarySidebar::dragMoveEvent(QDragMoveEvent* event) {
+    // qDebug() << "dragMoveEvent" << event->mimeData()->formats();
+    //  Start a timer to auto-expand sections the user hovers on.


Suggested change

// Start a timer to auto-expand sections the user hovers on.

// Start a timer to auto-expand sections the user hovers on.

ronso0 · 2025-10-21T09:36:13Z

+
+    if (!scrollToIndex) {
+        // restore saved scroll position after tree expansion completes
+        QTimer::singleShot(100, this, &WLibrarySidebar::restoreScrollPosition);


why do we need this?
IIUC this also a no-op in most cases (click), but requires reading from config

mxmilkiib · 2025-11-14T19:33:05Z

oops how do I github 🐾

ronso0

It looks like you added some minor bugfixes. Please create separate commits for those and explain what's wrong with the previous implementation.

ronso0 · 2025-11-17T10:26:02Z

+    m_pKeyNotation.reset(
+            new ControlObject(mixxx::library::prefs::kKeyNotationConfigKey));


Why reset?
And this is a std::unique_ptr, not a plain ControlObject*

ronso0 · 2025-11-17T10:28:52Z

+    // feature not found, can't search for child
+    if (featureRow < 0) {
+        return {};
+    }


This can be moved up, below for (int i = 0; i < m_sFeatures.size(); ++i) {

ronso0 · 2025-11-17T10:36:13Z

+                1, // stop at first match
+                Qt::MatchExactly | Qt::MatchRecursive);
+
+        if (!matches.isEmpty() && matches.first().isValid()) {


results of QAbstractItemModel::match() should never be invalid.
If you think we need to ensure validity, use

VERIFY_OR_DEBUG_ASSERT(matches.first().isValid()) { // some qWarning() return {}; }

ronso0 · 2025-11-17T10:38:01Z

+
+void WLibrarySidebar::setup(UserSettingsPointer pConfig) {
+    m_pConfig = pConfig;
+    // removed: connection to save on every scroll - now saves on shutdown only


irrelevant for devs touching this in the future, please remove

ronso0 · 2026-02-16T13:06:05Z

CI is failing. Both pre-commit and the build jobs.

mxmilkiib · 2026-02-18T11:57:42Z

rebased and restructured into 4 commits addressing ronso0's feedback. also fixed several bugs in the original implementation:

saveSelectionToConfig crashed on root feature nodes (internalPointer() == this, not a TreeItem*)
scheduleSelectionSave was never called from clicked()
child matching used a custom DataRole unknown to child models; switched to Qt::DisplayRole
activateDefaultSelection() was called unconditionally after restore, overwriting it
feature/child not activated on restore, so track table didn't populate without a click

also extended the feature to save/restore the selected track row within the table (via TrackId persisted to config, consumed in loadTrackModel).

ronso0 · 2026-02-26T22:59:53Z

FYI CI builds failed

ronso0 · 2026-02-26T23:00:52Z

.. and unrelated changes slipped in

mxmilkiib · 2026-07-05T02:14:52Z

why it this stale again?

I'm not "developing", just catching up

I think it's stale because the implementation was switched out halfway through the PR and it was too much to follow at the time, but afair the later commit set neatened things up

mxmilkiib · 2026-08-08T03:38:36Z

redone, actually confirmed working, still testing

now as two commits. the track reselection needed a bit extra workflow

hopefully it's methods are now concise and respectful enough of existing Mixxx systems

github-actions Bot added the library label Oct 8, 2025

daschuer requested changes Oct 8, 2025

View reviewed changes

Comment thread src/library/sidebarmodel.cpp Outdated

Comment thread src/library/sidebarmodel.cpp Outdated

ronso0 reviewed Oct 8, 2025

View reviewed changes

mxmilkiib force-pushed the feature/restore-last-library-selection branch 2 times, most recently from e76622b to b2bde95 Compare October 18, 2025 10:27

ronso0 reviewed Oct 18, 2025

View reviewed changes

mxmilkiib force-pushed the feature/restore-last-library-selection branch from b2bde95 to 28ec3de Compare October 19, 2025 01:21

github-actions Bot added ui build labels Oct 19, 2025

mxmilkiib force-pushed the feature/restore-last-library-selection branch 2 times, most recently from b1a8f86 to f188d9a Compare October 19, 2025 18:09

github-actions Bot added the qml label Oct 19, 2025

mxmilkiib force-pushed the feature/restore-last-library-selection branch from f188d9a to 5eb6c5a Compare October 19, 2025 18:14

mxmilkiib requested a review from daschuer October 19, 2025 19:48

mxmilkiib force-pushed the feature/restore-last-library-selection branch from 5eb6c5a to ad5067a Compare October 20, 2025 00:02

mxmilkiib marked this pull request as ready for review October 20, 2025 00:45

ronso0 reviewed Oct 21, 2025

View reviewed changes

mxmilkiib force-pushed the feature/restore-last-library-selection branch from a914597 to ff6507a Compare November 14, 2025 18:30

ronso0 requested changes Nov 17, 2025

View reviewed changes

This was referenced Feb 2, 2026

Add option to open Mixxx at the last used library/crate/playlist #15932

Closed

feat: Add option to restore last used library view #15934

Closed

ronso0 marked this pull request as draft February 6, 2026 13:54

mxmilkiib force-pushed the feature/restore-last-library-selection branch 2 times, most recently from 84a1e8e to d36954a Compare February 14, 2026 07:30

mxmilkiib force-pushed the feature/restore-last-library-selection branch from d36954a to 398eecf Compare February 17, 2026 00:32

github-actions Bot added controller mappings packaging labels Feb 17, 2026

mxmilkiib force-pushed the feature/restore-last-library-selection branch 2 times, most recently from 557302a to a78ea19 Compare February 26, 2026 09:22

mxmilkiib force-pushed the feature/restore-last-library-selection branch from a78ea19 to 6ee9eff Compare February 28, 2026 08:03

mxmilkiib force-pushed the feature/restore-last-library-selection branch 4 times, most recently from 50837a2 to 03d7fca Compare May 17, 2026 02:23

mxmilkiib force-pushed the feature/restore-last-library-selection branch from 03d7fca to bb0ffce Compare May 26, 2026 06:13

mxmilkiib force-pushed the feature/restore-last-library-selection branch from bb0ffce to 3bf3c18 Compare August 3, 2026 20:54

Milkii Brewster added 2 commits August 7, 2026 00:50

Restore last sidebar selection on restart

727a69b

Restore selected track in library pane on restart

e322da9

mxmilkiib force-pushed the feature/restore-last-library-selection branch from 3bf3c18 to e322da9 Compare August 7, 2026 15:04

mxmilkiib marked this pull request as ready for review August 8, 2026 03:35

	// Start a timer to auto-expand sections the user hovers on.
	// Start a timer to auto-expand sections the user hovers on.

		m_pKeyNotation.reset(
		new ControlObject(mixxx::library::prefs::kKeyNotationConfigKey));

Uh oh!

Uh oh!

Conversation

mxmilkiib commented Oct 8, 2025

Uh oh!

daschuer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronso0 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mxmilkiib commented Oct 8, 2025

Uh oh!

ronso0 commented Oct 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Oct 8, 2025

Uh oh!

mxmilkiib commented Oct 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Oct 18, 2025

Uh oh!

ronso0 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxmilkiib commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mxmilkiib commented Nov 14, 2025

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Feb 16, 2026

Uh oh!

mxmilkiib commented Feb 18, 2026

Uh oh!

ronso0 commented Feb 26, 2026

Uh oh!

ronso0 commented Feb 26, 2026

Uh oh!

mxmilkiib commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxmilkiib commented Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

ronso0 commented Oct 8, 2025 •

edited

Loading

ronso0 commented Oct 18, 2025 •

edited

Loading

ronso0 Oct 21, 2025 •

edited

Loading

mxmilkiib commented Jul 5, 2026 •

edited

Loading