add quick access to controller learning wizard via options menu by mxmilkiib · Pull Request #15577 · mixxxdj/mixxx

mxmilkiib · 2025-11-05T01:05:33Z

implements feature request from issue #12262 to provide quicker access to the midi controller learning wizard.

changes

options menu submenu

added "controller learning wizard" submenu under options menu
dynamically populated with enabled controllers only
shows "no controllers enabled" when no controllers are enabled
updates automatically when controllers are enabled/disabled

navigation

clicking a controller menu item opens preferences dialog
automatically navigates to that specific controller's page
expands the controllers tree and selects the correct item
user can then click the "learning wizard" button on that page

implementation

wmainmenubar: added menu creation and signal emission
mixxxmainwindow: connected signals, filters to show only enabled controllers
dlgprefcontrollers: added method to navigate to specific controller
dlgpreferences: added method to delegate to controllers dialog

follows the same architectural pattern as the existing vinyl control menu implementation for consistency.

fixes #12262

ronso0 · 2025-11-05T14:08:23Z

+            // Temporarily disconnect the mappingEnded signal to prevent
+            // showing the preferences dialog when the wizard closes
+            disconnect(pControllerDlg,
+                    &DlgPrefController::mappingEnded,
+                    m_pDlgPreferences,
+                    &DlgPreferences::show);
+
+            // Reconnect after wizard closes to restore normal behavior
+            connect(
+                    pControllerDlg,
+                    &DlgPrefController::mappingEnded,
+                    this,
+                    [this, pControllerDlg]() {
+                        // Restore the connection for future uses from preferences
+                        connect(pControllerDlg,
+                                &DlgPrefController::mappingEnded,
+                                m_pDlgPreferences,
+                                &DlgPreferences::show);
+                    },
+                    Qt::SingleShotConnection);


why do we need to disconnect this?
when a new mappng has been added, the mapping needs to be saved/applied, no?

stops prefs reopening

"disconnect only affects UI flow, not saving. prevents preferences dialog popping up when wizard is launched from menu instead of from within preferences. saving/applying happens in 'slotStopLearning()' before mappingEnded emits. single-shot reconnect restores normal behavior for preference-based launches."

maybe there is a more elegant way?

ronso0 · 2025-11-16T21:58:03Z

+    for (int i = 0; i < m_controllerPages.size(); ++i) {
+        DlgPrefController* pControllerDlg = m_controllerPages.at(i);
+        if (pControllerDlg && pControllerDlg->controller() == pController) {


Suggested change

for (int i = 0; i < m_controllerPages.size(); ++i) {

DlgPrefController* pControllerDlg = m_controllerPages.at(i);

if (pControllerDlg && pControllerDlg->controller() == pController) {

for (auto* pControllerDlg : m_controllerPages) {

if (pControllerDlg->controller() == pController) {

ronso0 · 2025-11-16T21:58:46Z

+            connect(
+                    pControllerDlg,


Suggested change

connect(

pControllerDlg,

connect(pControllerDlg,

ronso0 · 2025-11-16T22:06:19Z

+    // Show "No controllers enabled" if list is empty
+    if (m_controllerLearningActions.isEmpty()) {
+        auto* pNoControllersAction = new QAction(tr("No controllers enabled"), this);
+        pNoControllersAction->setEnabled(false);


This doesn't seem to work (here, with Qt 6.2.3), action is still enabled, can be selected and clicked

ronso0 · 2025-11-16T22:14:18Z

+                Qt::UniqueConnection);
+        // Initialize the menu with current controllers
+        slotUpdateControllerLearningMenu();
+    }


This doesn't work as intended, I don't see updated after startup.
The funtion that emits devicesChanged clearly states:

mixxx/src/controllers/controllermanager.cpp

Lines 191 to 193 in 604b32c

// NOTE: Currently this function is only called on startup. If hotplug is added, changes to the

// controller list must be synchronized with dlgprefcontrollers to avoid dangling connections

// and possible crashes.

You may try to connect to ControllerManager::mappingApplied but I'm not sure if the controller is already open because there is also a blocking call openController(pController);.
See here and #15524

mxmilkiib · 2026-02-18T12:20:24Z

addressed ronso0's nov 16 feedback:

connected to ControllerManager::mappingApplied in addition to devicesChanged — devicesChanged is only emitted once on startup (as noted in the comment at controllermanager.cpp:193), so the menu wasn't updating when a controller was enabled post-startup. mappingApplied fires after openController() is queued, so the menu now reflects open state correctly.
simplified openLearningWizard loop to range-for as suggested.

…m/main, fold into mixxxdj#15577

implements feature request from issue mixxxdj#12262 to provide quicker access to the midi controller learning wizard. - added "controller learning wizard" submenu under options menu - dynamically populated with enabled controllers only - hides when no controllers are enabled (fixes Qt 6.2.3 issue) - updates when controllers are enabled/disabled via mappingApplied signal - clicking a controller menu item opens preferences dialog - automatically navigates to that specific controller's page - expands the controllers tree and selects the correct item - user can then click the "learning wizard" button on that page - wmainmenubar: added menu creation and signal emission - mixxxmainwindow: connected signals, filters to show only enabled controllers - dlgprefcontrollers: added method to navigate to specific controller - dlgpreferences: added method to delegate to controllers dialog - use ControllerManager::mappingApplied instead of devicesChanged for menu updates - hide menu when empty instead of disabled action (fixes Qt 6.2.3 clickable issue) - flag-based solution instead of disconnect/reconnect for cleaner code flow - suppress preferences dialog show when wizard launched from menu follows the same architectural pattern as the existing vinyl control menu implementation for consistency. fixes mixxxdj#12262

- replace mappingApplied signal with direct Controller::openChanged connections - fixes menu not updating after startup - connect/disconnect as controllers are added/removed - properly tracks per-controller open state - keep setVisible workaround for Qt 6.2.3 (already correct) - replace suppress flag with preferences dialog visibility check - more elegant solution per ronso0 feedback - checks actual dialog visibility state at wizard start - only emits mappingStarted/mappingEnded if dialog was visible

Connect to ControllerManager::mappingApplied in addition to devicesChanged. devicesChanged is only emitted once on startup (per the comment in controllermanager.cpp); mappingApplied fires after a controller is opened when a mapping is applied post-startup, so the menu now updates correctly when controllers are enabled. Also simplify openLearningWizard loop to range-for per review.

DlgControllerLearning is parented to DlgPrefController, which is a child of DlgPreferences. Previously, mappingStarted() was emitted after show(), causing DlgPreferences::hide() to cascade-hide the wizard immediately. Emit mappingStarted() before creating and showing the wizard so the prefs dialog is already hidden when the wizard appears.

github-actions Bot added ui preferences controller backend labels Nov 5, 2025

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch from bb8a876 to 6546404 Compare November 5, 2025 04:50

ronso0 reviewed Nov 5, 2025

View reviewed changes

mxmilkiib marked this pull request as ready for review November 15, 2025 07:21

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch from 6546404 to 2978aa3 Compare November 15, 2025 17:55

ronso0 requested changes Nov 16, 2025

View reviewed changes

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch from 5c79bd7 to e5d50a7 Compare January 30, 2026 03:29

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch 5 times, most recently from 2caf883 to 46eb90d Compare February 15, 2026 03:47

mxmilkiib pushed a commit to mxmilkiib/mixxx that referenced this pull request Feb 22, 2026

INTEGRATION.md: mixxxdj#16018 root cause wrong — not a bug on upstrea…

27b090c

…m/main, fold into mixxxdj#15577

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch from 642d2d9 to 56e185c Compare February 22, 2026 10:56

mxmilkiib requested a review from ronso0 February 28, 2026 08:52

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch 4 times, most recently from 1d37504 to c84cc15 Compare May 17, 2026 02:23

Milkii Brewster added 6 commits May 26, 2026 07:13

remove std::as_const wrappers from range-based for loops

a9cb3bd

Fix clazy range-loop-detach warnings in dlgprefcontrollers.cpp

bc1bbf9

mxmilkiib force-pushed the feature/2025.11nov.04-controller-wizard-quick-access branch from c84cc15 to 7f001f0 Compare May 26, 2026 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add quick access to controller learning wizard via options menu#15577

add quick access to controller learning wizard via options menu#15577
mxmilkiib wants to merge 6 commits into
mixxxdj:mainfrom
mxmilkiib:feature/2025.11nov.04-controller-wizard-quick-access

mxmilkiib commented Nov 5, 2025

Uh oh!

ronso0 Nov 5, 2025

Uh oh!

mxmilkiib Nov 14, 2025

Uh oh!

ronso0 Nov 16, 2025

Uh oh!

ronso0 Nov 16, 2025

Uh oh!

ronso0 Nov 16, 2025

Uh oh!

ronso0 Nov 16, 2025

Uh oh!

ronso0 Nov 16, 2025

Uh oh!

mxmilkiib commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// NOTE: Currently this function is only called on startup. If hotplug is added, changes to the
	// controller list must be synchronized with dlgprefcontrollers to avoid dangling connections
	// and possible crashes.

Uh oh!

Conversation

mxmilkiib commented Nov 5, 2025

changes

options menu submenu

navigation

implementation

Uh oh!

ronso0 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

mxmilkiib Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

mxmilkiib commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants