improve waveform cache size display format - #15578
Merged
ronso0 merged 1 commit intoFeb 16, 2026
Merged
Conversation
Contributor
Author
|
hmmmm and more than once. what would cause that form of failure? |
Contributor
Author
|
does the test confit need a fix, or would that have been a temporary glitch? can someone please trigger the testing again? |
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
November 6, 2025 07:07
f7f977d to
c1a1d2d
Compare
Swiftb0y
reviewed
Nov 6, 2025
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
November 15, 2025 17:55
9c32c8d to
af5281d
Compare
Swiftb0y
reviewed
Nov 18, 2025
Swiftb0y
left a comment
Swiftb0y
left a comment
Member
There was a problem hiding this comment.
Thank you. Would you mind squashing the three commits into a single one?
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
January 30, 2026 03:29
6be77ee to
bacc6fc
Compare
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
2 times, most recently
from
February 8, 2026 14:57
1d98c9d to
1a47ac7
Compare
mxmilkiib
pushed a commit
to mxmilkiib/mixxx
that referenced
this pull request
Feb 8, 2026
…feedback addressed
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
February 9, 2026 07:36
1a47ac7 to
015c0d3
Compare
ronso0
reviewed
Feb 10, 2026
ronso0
left a comment
ronso0
left a comment
Member
There was a problem hiding this comment.
Thank you for the fixup, looks good.
Just dropped a comment about the units/prefixes
| QString sizeMebibytes = QString::number( | ||
| numBytes / (1024.0 * 1024.0), 'f', 2); | ||
|
|
||
| QString sizeText = QLocale().formattedDataSize(numBytes); |
Member
There was a problem hiding this comment.
IMO we only need a precision of 1, and --personally-- I'd prefer the old format with SI prefixes (kB, MB, GB), see https://doc.qt.io/qt-6/qlocale.html#DataSizeFormat-enum
just because it's used on all (major) marketplaces and even in Mixxx conversations I never encountered the new IEC prefixes (kiB, MiB, GiB)
Wdyt?
Contributor
Author
There was a problem hiding this comment.
eh i can live with that, cool
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
February 14, 2026 01:30
015c0d3 to
b187977
Compare
mxmilkiib
force-pushed
the
feature/2025.11nov.05-waveform-cache-size-format
branch
from
February 14, 2026 07:30
b187977 to
a3a2692
Compare
acolombier
pushed a commit
to acolombier/mi3x
that referenced
this pull request
Feb 17, 2026
…-waveform-cache-size-format improve waveform cache size display format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes the waveform cache size display to automatically use GiB when the size is >= 1024 MiB for better readability.
before: "52533.06 MiB"
after: "51.30 GiB"
the format still shows MiB for smaller caches (< 1 GiB).
fixes #14874