Skip to content

rename Reloop Beatmix MK2 controller files to denote they are for the MK2 - #15615

Merged
ronso0 merged 1 commit into
mixxxdj:mainfrom
mxmilkiib:bugfix/2025.11nov.16-reloop-beatmix-mk2-naming
Feb 11, 2026
Merged

rename Reloop Beatmix MK2 controller files to denote they are for the MK2#15615
ronso0 merged 1 commit into
mixxxdj:mainfrom
mxmilkiib:bugfix/2025.11nov.16-reloop-beatmix-mk2-naming

Conversation

@mxmilkiib

Copy link
Copy Markdown
Contributor

off the back of discussion on #12422

if the MK1 files get called that, the current MK2 filenames will be too ambiguous

@mxmilkiib
mxmilkiib force-pushed the bugfix/2025.11nov.16-reloop-beatmix-mk2-naming branch from 546691b to 2bae359 Compare January 30, 2026 03:29
@mxmilkiib
mxmilkiib force-pushed the bugfix/2025.11nov.16-reloop-beatmix-mk2-naming branch from 2bae359 to 832dacd Compare February 8, 2026 14:57
@mxmilkiib
mxmilkiib force-pushed the bugfix/2025.11nov.16-reloop-beatmix-mk2-naming branch from 832dacd to 17cb3b8 Compare February 9, 2026 07:36
@ronso0

ronso0 commented Feb 10, 2026

Copy link
Copy Markdown
Member

I have no objections. Why is it still a draft?
The only downside of this optimization is that users who have the old mapping loaded will be surprised, once after updating. Which is acceptable IMHO

@ronso0

ronso0 commented Feb 10, 2026

Copy link
Copy Markdown
Member

May I ask why you keep rebasing small branches like this that have no conflicts with the target branch?

@mxmilkiib
mxmilkiib marked this pull request as ready for review February 11, 2026 03:55
@mxmilkiib

Copy link
Copy Markdown
Contributor Author

I updating each feature branch to the latest main so I can be sure nothing conflicts, esp. when it comes to merging multiple branches

@ronso0

ronso0 commented Feb 11, 2026

Copy link
Copy Markdown
Member

Because I do not want to do this, and because my pending feature branches may have conflicts with each other, I use a helper which basically cherry-picks all commits of branch xyz into my production branch. Then I resolve conflicts individually (git rerere helps avoiding repetetive manual resolutions btw).
In short it's git cherry-pick $(git merge-base [base branch] [branch])..[branch]
And here's the definition from my git.plugin.sh for zsh/OhMyZsh:

# cherry-pick all commits of branch $1 (opt: relative to branch $2)
# usage: gcpb branch-name [optional: base branch]
function gcpb() {
  if [[ "$#" == 0 ]]; then
    return
  fi

  local branch=$1
  local base="mixxx/main"
  if [[ "$#" == 2 ]]; then
    base="mixxx/"$2
  fi
  git cherry-pick $(git merge-base $base $branch)..$branch
}
compdef _git gcpb=git-checkout

@ronso0
ronso0 enabled auto-merge February 11, 2026 11:52

@ronso0 ronso0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@ronso0
ronso0 merged commit 1bd3c43 into mixxxdj:main Feb 11, 2026
14 of 15 checks passed
@ronso0

ronso0 commented Feb 11, 2026

Copy link
Copy Markdown
Member

Oh, we could as well have merged this to 2.6, or even 2.5 in case there'll be another bugfix release before 2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants