Numark Mixtrack Pro mapping fix and upgrade v.2.5 - 2.6 by vespadj · Pull Request #15629 · mixxxdj/mixxx

vespadj · 2025-11-17T20:52:23Z

This PR enhances the Numark Mixtrack Pro controller mapping with several improvements and modernizations:

Refactoring and fixes: Improved jogWheel, touchWheel, and Loop functionality, with better handling of functions.
New features: Added settings controls, brake/soft start options (ready for 2.6+), revamp EQ knobs, selector knob, pitch bend buttons alternative mapping, and updated beat sync to use sync_enabled.
Code modernization: Modernized JavaScript functions, removed unused code, and applied ESLint/Prettier formatting.
Mapping upgrades: Upgraded XML from v1.2 to v2.5, changed deleteKey to shiftKey, and removed old [Flanger] references.

All changes have been tested and are ready for integration.

…ck-qml-proxy feat: refactor player proxy and create separated track proxy

…rdware-setting fix: prevent unnecessary need restart popup

…rm-on-qml feat: add more renderers on QML

…veform-zoom-exp QML: Improve waveform zoom exp

…in a safe way

Use FindWrapOpenGL.cmake. It allows X11-less system. Set link_target to OpenGL::OpenGL, GLVND-based. If not found, use OpenGL:GL. Furthermore, adding a __X11__ definition so that the screensaver that requires Xlib is now optional. Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>

X11-less - Use FindWrapOpenGL

add 'LoadTrackFromPreviewDeck' control

Because X11/XKBlib.h is a part of libX11 Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>

Don't try localeFromXkbSymbol w/o __X11__ defined

…ch-2.6-to-main

Merge changes from `2.6` into `main`

…pping_validation_test and controllerscriptenginelegacy_test executable without crash

…ch-2.6-to-main

Merge changes from `2.6` into `main`

…ch-2.6-to-main

Merge changes from `2.6` into `main`

…rProxy Create JavascriptPlayerProxy

Merge changes from `2.6` into `main`

Don't use asKeyValueRange() when building with Qt 6.2

vespadj · 2025-12-03T21:53:53Z

I look that scratch part can be simplified and I'm working on it.

Fix LedTimers, was with random index --> raise some few errors sometime.
Review, simplified and commented wheel Touch and Turn, still considering inertia in backspin.
Add scratch Sensibility in Mapping settings , default 600.
Update manual
Done!

github-actions · 2026-03-11T00:13:15Z

This PR is marked as stale because it has been open 90 days with no activity.

ronso0 · 2026-03-11T10:28:49Z

Okay, this looks good.
Sorry for letting this wait so long!

Please rebase onto 2.6 and try to adjust commit messages to reflect the changes ("reviews 3" is not helpful when looking at the commit history later on). Maybe even squash related commits? But I'll leave that up to you as it might be cumbersome.
Use git rebase -i [target branch], the -i flag means to use the interactive editor view where you can remove unrelated commits from main, reorder commits and reword commit messages.

…Start splitted

vespadj · 2026-04-14T22:02:59Z

I done. I'm not sure about the git push command, please give me instructions if it's necessary, for this PR and the relative manual (link above).
Thank you so much for your constant support.

ronso0 · 2026-04-15T10:04:21Z

Thanks. You force-pushed but changing the base here to 2.6 (now 309 commits) indicates you didn't rebase onto 2.6

I've found some nits in the last commit(s), minor requests only, and will leave a review soon.

ronso0

another review run..

Btw did you close the previous review convos yourslef or did this happen automatically after you force-pushed?
For the record: convos are closed by reviewers. Else we don't know which have been actually resolved and need to go through all again..

ronso0 · 2026-04-15T10:06:51Z

+    NumarkMixTrackPro.isPflOn = [0, 0];
+    engine.makeConnection("[Channel1]", "pfl", (value) => {
+        NumarkMixTrackPro.isPflOn[0] = value;
+        console.log("NumarkMixTrackPro.isPflOn[0]", NumarkMixTrackPro.isPflOn[0]);


debug leftover?
if yes, please remove

ok in next commit.

ronso0 · 2026-04-15T10:18:01Z

+    NumarkMixTrackPro.LedTimer = function(id, led, count, state) {
+        this.id = id;
+        this.led = led;
+        this.count = count;
+        this.state = state;
+    };


where is LedTimer used?

not used, deleted in next commit.

ronso0 · 2026-04-15T10:28:30Z

+NumarkMixTrackPro.setStutterBeat = function(deck, value) {
+    const secondsBlink = 30;
+    const secondsToEnd =
+        engine.getParameter(`[Channel${deck}]`, "duration") *
+        (1 - engine.getParameter(`[Channel${deck}]`, "playposition"));
+
+    if (
+        secondsToEnd < secondsBlink &&
+        secondsToEnd > 1 &&
+        engine.getParameter(`[Channel${deck}]`, "play")
+    ) {
+        // The song is going to end
+        NumarkMixTrackPro.setLED(NumarkMixTrackPro.leds[deck].Cue, value);
+    }
+
+    NumarkMixTrackPro.setLED(NumarkMixTrackPro.leds[deck].stutter, value);
+};


I suggest to connect to end_of_track
That way users can define the threshold in Preferences -> Waveforms

And the LED currently doesn't blink, or does it?

OK, done. Stutter LED blink at each beat and Cue blink to at the end of the song.

used makeConnection in the proper way with group. Deleted two callback functions, and renamed the rest.

ronso0 · 2026-04-15T10:33:38Z

+NumarkMixTrackPro.Stutter1Beat = function(value) {
+    NumarkMixTrackPro.setStutterBeat(1, value);
+};
+
+NumarkMixTrackPro.Stutter2Beat = function(value) {
+    NumarkMixTrackPro.setStutterBeat(2, value);
+};


These wrappers are not necessary if you use a lambda (or whatever that is called in js) for the stuterbeat makeConnections like you do for other connections, then just call setStutterBeat (rename to flashStutterLED?)

oh, kinda already covered by Nicko's review #15629 (comment)

So will you resolve this conversation?

Niko's review, yes.
his was about the wrappers, I'm saying we only need NumarkMixTrackPro.setStutterBeat(deck, value) and call it from the lambdas

(ok, see up)

ronso0 · 2026-04-15T10:37:15Z

+                variable="numarkMixTrackPro_brakeEnabled"
+                type="boolean"
+                default="false"
+                label='Play/Pause performs Brake and Soft Start if "SCRATCH LED" is on. [Require Mixxx v.2.6+]'>


The tooltip mentioning 2.6+ is however still in place in the xml

ronso0 · 2026-04-15T10:41:02Z

+NumarkMixTrackPro.Channel1Clip = function(value) {
+    NumarkMixTrackPro.clipLED(value, NumarkMixTrackPro.leds[1].sync);
+};
+
+NumarkMixTrackPro.Channel2Clip = function(value) {
+    NumarkMixTrackPro.clipLED(value, NumarkMixTrackPro.leds[2].sync);
+};


ronso0 · 2026-04-15T10:43:53Z

        // cargar el tema con el pitch en 0
        engine.softTakeover(group, "rate", false);
-        engine.setValue(group, "rate", 0);
+        engine.setParameter(group, "rate", 0.5);


as per Niko's review:
don't do this in the mapping, it's a user setting that can be set in Preferences -> Decks -> Speed / Key options

ronso0 · 2026-04-15T10:47:22Z

+        if (engine.getValue(group, "play")) {
+            engine.setValue(group, "play", 0);
+        } else {
+            engine.setValue(group, "play", 1);
+        }


can be simply
script.toggleControl(group, "play");

ronso0 · 2026-04-15T10:47:58Z

+        if (engine.getParameter(group, "quantize")) {
+            engine.setParameter(group, "quantize", 0);
+        } else {
+            engine.setParameter(group, "quantize", 1);
+        }


script.toggleControl(group, "quantize");

acolombier and others added 30 commits May 18, 2025 23:42

feat: refactor player proxy and create separated track proxy

2aeee0a

Merge pull request mixxxdj#14516 from acolombier/fix/split-player-tra…

7e9489f

…ck-qml-proxy feat: refactor player proxy and create separated track proxy

fix: prevent unnecessary needed restart popup

ffbf0bc

Merge pull request mixxxdj#14830 from acolombier/fix/prevent-popup-ha…

a5785c0

…rdware-setting fix: prevent unnecessary need restart popup

feat: add more renderers on QML

38a400a

fix: disable assert if stem aren't used

941cfdf

Merge pull request mixxxdj#14515 from acolombier/feat/add-more-wavefo…

a28ad6b

…rm-on-qml feat: add more renderers on QML

chore(QML): improve waveform zoom experience

70b1799

Merge pull request mixxxdj#14850 from acolombier/chore/qml-improve-wa…

1dd7a35

…veform-zoom-exp QML: Improve waveform zoom exp

Create JavascriptPlayerProxy to expose track infos to JS controllers …

d960c0a

…in a safe way

Merge pull request mixxxdj#14574 from PPN-SD/x11less

16c9c13

X11-less - Use FindWrapOpenGL

Merge pull request mixxxdj#14434 from ronso0/load-from-previewdeck

837f0ab

add 'LoadTrackFromPreviewDeck' control

Merge remote-tracking branch 'upstream/2.6'

ffe31e3

Don't try localeFromXkbSymbol w/o __X11__ defined

ebeff35

Because X11/XKBlib.h is a part of libX11 Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>

Merge pull request mixxxdj#14949 from PPN-SD/main

7265da0

Don't try localeFromXkbSymbol w/o __X11__ defined

Merge branch '2.6' of https://github.com/mixxxdj/mixxx into sync-bran…

eb894b2

…ch-2.6-to-main

Merge pull request mixxxdj#14963 from mixxxdj/sync-branch-2.6-to-main

1f52680

Merge changes from `2.6` into `main`

Made JS code containing the new engine.getPlayer API in controller_ma…

7b116a4

…pping_validation_test and controllerscriptenginelegacy_test executable without crash

Merge branch '2.6' of https://github.com/mixxxdj/mixxx into sync-bran…

9ea8af0

…ch-2.6-to-main

Merge branch '2.6' of https://github.com/mixxxdj/mixxx into sync-bran…

4309532

…ch-2.6-to-main

Merge pull request mixxxdj#14969 from mixxxdj/sync-branch-2.6-to-main

fb762a2

Merge changes from `2.6` into `main`

Merge branch '2.6' of https://github.com/mixxxdj/mixxx into sync-bran…

0766e7b

…ch-2.6-to-main

Merge pull request mixxxdj#14973 from mixxxdj/sync-branch-2.6-to-main

14c19a5

Merge changes from `2.6` into `main`

Add tests for JavascriptPlayerProxy API

80e959a

Merge branch '2.6' into 'main'

c695d75

Merge pull request mixxxdj#14314 from christophehenry/JavascriptPlaye…

07bcb86

…rProxy Create JavascriptPlayerProxy

Merge pull request mixxxdj#14979 from mixxxdj/sync-branch-2.6-to-main

1923fc2

Merge changes from `2.6` into `main`

Dont use asKeyValueRange() when building with Qt 6.2

b7b4c33

Merge pull request mixxxdj#14981 from daschuer/qt62

f5a6c30

Don't use asKeyValueRange() when building with Qt 6.2

ronso0 reviewed Dec 4, 2025

View reviewed changes

Comment thread res/controllers/Numark Mixtrack Pro.midi.xml

ronso0 reviewed Dec 4, 2025

View reviewed changes

Comment thread res/controllers/Numark-Mixtrack-Pro-scripts.js

github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Mar 11, 2026

github-actions Bot removed the stale Stale issues that haven't been updated for a long time. label Mar 12, 2026

MixtrackPro: fix ledTimers, backspin inertia, settings Brake and Soft…

3c6db1a

…Start splitted

vespadj force-pushed the mixtrack-pro-fix branch from ebf1d30 to 3c6db1a Compare April 14, 2026 21:14

ronso0 changed the base branch from main to 2.6 April 15, 2026 10:02

ronso0 requested changes Apr 15, 2026

View reviewed changes

MixtrackPro: fix reviewer note

8ad03c2

github-actions Bot added skins effects library engine ui build autodj code quality preferences waveform vinylcontrol browse soundio qml controller backend developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels Apr 15, 2026

Uh oh!

Uh oh!

Conversation

vespadj commented Nov 17, 2025

Uh oh!

vespadj commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

ronso0 commented Mar 11, 2026

Uh oh!

vespadj commented Apr 14, 2026

Uh oh!

ronso0 commented Apr 15, 2026

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants