Clamp user offset values to less than 1 beat #15906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This sounds like a bug-fix. Shall we target it to 2.5 or 2.6? |
daschuer
requested changes
Jan 26, 2026
Member
Author
yes, I think this is ok for 2.5 |
Occasionally seek operations can cause the user offset value to go quite high -- it never makes sense for the user offset to be more than 1 beat by definition, so clamp it to that value. Signed-off-by: Owen Williams <[email protected]>
Co-authored-by: Daniel Schürmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally seek operations can cause the user offset value to go quite high -- it never makes sense for the user offset to be more than 1 beat by definition, so reduce it to below that value like a mod operation.