Skip to content

Incoming tracks folder - #15940

Open
daschuer wants to merge 18 commits into
mixxxdj:mainfrom
daschuer:incomming_tracks
Open

Incoming tracks folder #15940
daschuer wants to merge 18 commits into
mixxxdj:mainfrom
daschuer:incomming_tracks

Conversation

@daschuer

@daschuer daschuer commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR introduces an incomimg track folder that is watched for new tracks. Once a track appears the user can either preview the track in a preview deck or append it to auto DJ or do nothing:

grafik grafik

This covers the use case if you download an audience wish during a performance.

This shall partially fix #13192

ronso0
ronso0 reviewed Feb 3, 2026
View reviewed changes

@ronso0 ronso0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature!
Looks good already, left some remarks.

Does it currently require a restart to activate the dir watcher?

Comment thread src/library/trackcollectionmanager.cpp Outdated
Comment thread src/preferences/dialog/dlgpreflibrarydlg.ui Outdated
Comment thread src/mixxxmainwindow.cpp
pLibrary->appendTracksToAutoDJ({pTrack->getId()});
pLibrary->showAutoDJ();
}
}

@ronso0 ronso0 Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to add the AutoDJ button to the existing summary dlg.
Besides, this is now only shown for single new tracks, why not show it if more tracks have been discovered? Like when you paste tracks from a guest's USB into incoming?

@daschuer daschuer Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure, if there is a use case for that. My use case covers only a single track during a performance.

I can hover confirm that users may want to listen to all new track that have been collected since the last start.
We have also the adjustable new Track filter in the analyser view in the other PR #15862. How about showing them?

@daschuer
daschuer force-pushed the incomming_tracks branch 2 times, most recently from da19d4c to 4610a4e Compare February 8, 2026 16:35
@daschuer daschuer changed the title Incomming tracks folder Incoming tracks folder Feb 8, 2026
@daschuer

daschuer commented Feb 8, 2026

Copy link
Copy Markdown
Member Author

This is now complete, with Sandboxing, applying preference changes on the fly and ignoring temporary half written downloads. Fixed also some edge cases found during testing.

Sorry, I had to rebase everything because of a nasty typo in "incoming".

@ronso0

ronso0 commented Mar 17, 2026

Copy link
Copy Markdown
Member

Conflicts have emerged, please rebase.

Why isn't the dir scan recursive?
I understand the original use case is to get notified about single new tracks, but I'd like to point another one again, which is dropping a directory in the incoming folder, either from a (guest) thumb drive or when extracting a zip from bandcamp for example.
Or do I misinterpret the m_recursive flag?

@daschuer

daschuer commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

Ah yes. I can confirm the use-case of a recursive scan of a new folder inside the watched folder. I will take a look.

@ronso0

ronso0 commented Jun 11, 2026

Copy link
Copy Markdown
Member

I'll take a closer look soonish, manual test is still pending.
Unfortunately some conflicts have emerged. Feel free to rebase, luckily commits are granular so I don't mind re-reviewing.
Btw 0a9e45e is empty.

@ronso0 ronso0 mentioned this pull request Jun 13, 2026
Open
13 tasks
@ronso0 ronso0 mentioned this pull request Jul 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronso0 ronso0 ronso0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

autodj library preferences scanner ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically scan music directories in the background

2 participants

@daschuer @ronso0