Skip to content

AutoDJ: Reset AutoDJ when deck orientation changes - #15963

Merged
daschuer merged 2 commits into
mixxxdj:2.6from
ywwg:autodj-orientation
Aug 2, 2026
Merged

AutoDJ: Reset AutoDJ when deck orientation changes#15963
daschuer merged 2 commits into
mixxxdj:2.6from
ywwg:autodj-orientation

Conversation

@ywwg

@ywwg ywwg commented Feb 8, 2026

Copy link
Copy Markdown
Member

When deck orientation changes, disable and then enable AutoDJ in case the program is now in an invalid state.

Fixes #15962

@daschuer daschuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The off/on cycle does not produce a nice message when changing the orientation of the playing deck.
I think you need to special case that. I suggest to disable the AutoDJ and pop up a message.
"Playing deck orientation changed. Auto DJ disabled."

@ywwg

ywwg commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

in that case I will add the message and then not try to trigger it back on. better to just turn it off and let the DJ figure out what they want to do.

@ywwg

ywwg commented Mar 7, 2026

Copy link
Copy Markdown
Member Author

I can rebase on 2.6 if you like

@ywwg
ywwg requested a review from daschuer March 7, 2026 21:43
@ywwg
ywwg force-pushed the autodj-orientation branch from a064ee9 to 43285a1 Compare March 7, 2026 21:44
@ywwg

ywwg commented Mar 7, 2026

Copy link
Copy Markdown
Member Author

"Playing deck orientation changed. Auto DJ disabled."

I'm reusing an existing error message but I can create a new one

@ronso0

ronso0 commented Mar 7, 2026

Copy link
Copy Markdown
Member

Can the dialog have a button or checkbox to re-enable it?
Or will this actually be a one-time issue only, meaning the DJ will learn quickly that they shouldn't mess with deck orientation when Auto DJ is running?
(didn't test or check the code, just stopping by)

@acolombier acolombier added this to the 2.6.0 milestone Mar 13, 2026
@acolombier
acolombier changed the base branch from 2.5 to 2.6 March 13, 2026 16:32
@ywwg

ywwg commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

I am guessing this will be a one-time issue -- in my case I flipped a switch on my controller to change deck orientation and then mixxx crashed. In this case, mixxx would have popped up the box and I would have realized I had to move the switch back.

ywwg added 2 commits April 2, 2026 09:53
When deck orientation changes, disable and then enable AutoDJ in case the program is now in an invalid state.

Fixes mixxxdj#15962

Signed-off-by: Owen Williams <owilliams@mixxx.org>
Signed-off-by: Owen Williams <owilliams@mixxx.org>
@ywwg
ywwg force-pushed the autodj-orientation branch from 43285a1 to 196d13c Compare April 2, 2026 14:11
@ywwg

ywwg commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

@daschuer did you still want a different dialog box?

@github-actions

Copy link
Copy Markdown

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Jul 11, 2026

@daschuer daschuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer
daschuer merged commit 47d4abe into mixxxdj:2.6 Aug 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autodj library stale Stale issues that haven't been updated for a long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants