AutoDJ: Reset AutoDJ when deck orientation changes - #15963
Conversation
daschuer
left a comment
There was a problem hiding this comment.
The off/on cycle does not produce a nice message when changing the orientation of the playing deck.
I think you need to special case that. I suggest to disable the AutoDJ and pop up a message.
"Playing deck orientation changed. Auto DJ disabled."
|
in that case I will add the message and then not try to trigger it back on. better to just turn it off and let the DJ figure out what they want to do. |
|
I can rebase on 2.6 if you like |
I'm reusing an existing error message but I can create a new one |
|
Can the dialog have a button or checkbox to re-enable it? |
|
I am guessing this will be a one-time issue -- in my case I flipped a switch on my controller to change deck orientation and then mixxx crashed. In this case, mixxx would have popped up the box and I would have realized I had to move the switch back. |
When deck orientation changes, disable and then enable AutoDJ in case the program is now in an invalid state. Fixes mixxxdj#15962 Signed-off-by: Owen Williams <owilliams@mixxx.org>
Signed-off-by: Owen Williams <owilliams@mixxx.org>
|
@daschuer did you still want a different dialog box? |
|
This PR is marked as stale because it has been open 90 days with no activity. |
When deck orientation changes, disable and then enable AutoDJ in case the program is now in an invalid state.
Fixes #15962