libxwax: Exchange the static delayline with a generic ringbuffer #15965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclsn
force-pushed
the
feat/generalized-ringbuffer
branch
7 times, most recently
from
4c71326 to
d4be53e
Compare
This ringbuffer is more versatile and can also be used for later filter implementations.
jclsn
force-pushed
the
feat/generalized-ringbuffer
branch
from
d4be53e to
1696c12
Compare
Contributor
Author
|
Should be fine now. No idea why Windows ARM64 failed. It went through last time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ringbuffer is more versatile and can also be used for later filter implementations.
This is needed because I want to write a generalized filter function that can generate FIR filters at runtime, which need a lot of memory for the delayline.
The FIR filters are needed, because I need to exchange Exponential Moving Average filter with one, because it is IIR and distorts phase. Phase distortion means that it exhibits different delays for different frequencies -> non-constant group delay, which would in theory increase sticker drift, because the delay would be higher when scratching than during normal playback.