fix: prevent repeated load operation on QmlPlayerProxy - #15970
Merged
acolombier merged 1 commit intoFeb 12, 2026
Conversation
Add early-return guards to loadTrack() and loadTrackFromLocation() to skip the load if the requested track is already loaded in the player. This prevents unnecessary unload/reload cycles, avoiding audible glitches and redundant signal emissions. loadTrackFromLocationUrl() is covered implicitly since it delegates to loadTrackFromLocation(). Fixes: mixxxdj#14809
Contributor
Author
|
Am confused here? Are QML issues not to be touched? I don't know what core dev self-assigning a PR mean, so am sorry if I misunderstood anything. |
Member
|
Fixing QML issues is very welcome! I guess Antoine just clicked on the wronk link, which assigned the issue to him, instead of self-requesting a review of your work. |
acolombier
self-requested a review
February 12, 2026 23:41
Member
|
Apologies, this is indeed very welcome! I saw the notification from my phone and I wanted to make sure I wouldn't forget to test and review this PR. As @JoergAtGithub rightfully pointed, I meant to self-request a review but I got yet again confused by the poor Github app. Sorry for the wrong signal and thank for helping the QML effort! |
Contributor
Author
|
No worries. Looking forward to make more meaningful changes in qml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add early-return guards to
loadTrack()andloadTrackFromLocation()to skip the load if the requested track is already loaded in the player. This prevents unnecessary unload/reload cycles, avoiding audible glitches and redundant signal emissions.loadTrackFromLocationUrl()is covered implicitly since it delegates toloadTrackFromLocation().Fixes: #14809