Skip to content

(fix) Tracks: avoid GUI lag when restoring large track selections #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywwg merged 1 commit into from
Feb 26, 2026
Merged

(fix) Tracks: avoid GUI lag when restoring large track selections #15973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions src/widget/wlibrarytableview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,45 @@ bool WLibraryTableView::restoreTrackModelState(
verticalScrollBar()->setValue(state->verticalScrollPosition);
horizontalScrollBar()->setValue(state->horizontalScrollPosition);

auto* pSelection = selectionModel();
pSelection->clearSelection();
// Build a selection range rather than selecting each track individually,
// which can lag the GUI by spamming selectionChanged() handlers.
QItemSelectionModel* pSelectionModel = selectionModel();
pSelectionModel->clearSelection();
QItemSelection newSelection;
QModelIndexList selectedRows = state->selectedRows;
QModelIndex topLeft;
QModelIndex bottomRight;
if (!selectedRows.isEmpty()) {
for (auto index : std::as_const(selectedRows)) {
pSelection->select(index,
QItemSelectionModel::Select | QItemSelectionModel::Rows);
// In saveTrackModelState() we fill state->selectedRows with the sorted
// rows, hence no need to sort here.
for (const QModelIndex& index : std::as_const(selectedRows)) {
if (!topLeft.isValid()) {
// start new range. only done once for first row
topLeft = index;
bottomRight = index;
continue;
}

if (index.row() == bottomRight.row() + 1) {
// continuous range
bottomRight = index;
continue;
} else {
// prev index was end of range, add current range to selection
// and start a new one
newSelection.select(topLeft, bottomRight);
topLeft = index;
bottomRight = index;
}
}

// If we reached end, submit the last selection
if (bottomRight == selectedRows.last()) {
newSelection.select(topLeft, bottomRight);
}
}
pSelectionModel->select(newSelection,
QItemSelectionModel::Select | QItemSelectionModel::Rows);

@ronso0 ronso0 Feb 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: all this only works because the list returned by QItemSelectionMdel::selectedRows() is sorted by row number

@daschuer daschuer Feb 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was puzzled if this is the case. Can you add this as a source code comment?

@ronso0 ronso0 Feb 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will add a comment. the docs aren't explicit about this so I looked it up in the Qt sources
selectedRows() and QItemSelectionRange

@ronso0 ronso0 Feb 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.


QModelIndex currIndex = state->currentIndex;
restoreCurrentIndex(currIndex);
Expand Down