Add Mono recording support for all Encoders - #15977
Merged
Merged
Conversation
Member
|
All green! Thank you :-) |
daschuer
approved these changes
Feb 15, 2026
daschuer
left a comment
daschuer
left a comment
Member
There was a problem hiding this comment.
LGTM, And congratulations to your first PR.
Member
|
Why is this still a Draft? Once the Draft state is removed, I can merge it to main. |
dheeraj23195
marked this pull request as ready for review
February 15, 2026 12:59
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements True Mono Recording Support as detailed in Issue #15180 . I have, after discussions with the community and maintainers, implemented an Independent Recording output option. So if the user wants the audio output in stereo but the recording output in Mono, that is possible (or any of the other three permutations).
Also, this is the GUI Change that will take place due to the recording output preference added:
**Before: **
**After: **
Note: This is a clean resubmission of #15947 with properly formatted code and a single commit for easier review trying to pass the code style check as it kept failing on the last pr due to majority of commits being without pre-commit.