DlgTrackInfo: add BPM lock toggle to BPM tab by Swarnadip-Kar · Pull Request #16025 · mixxxdj/mixxx

Swarnadip-Kar · 2026-02-22T11:59:03Z

Summary

Adds a Lock/Unlock BPM button to the BPM tab in the Track Editor dialog (DlgTrackInfo).

Problem

When BPM is locked, the entire BPM tab is disabled with no way to unlock it from within the Track Editor. Users must close the dialog and use the track context menu to unlock BPM.

Changes

Added a QPushButton (bpmLock) to the BPM tab in dlgtrackinfo.ui
Added slotBpmLockClicked() slot to handle button clicks
Modified reloadTrackBeats() to individually disable editing controls instead of the whole tab
Lock button text dynamically updates to "Lock BPM" / "Unlock BPM"

How to test

Open Mixxx and load a track into the library
Right-click the track → Properties → BPM tab
Click "Lock BPM" → all editing controls should become disabled
Click "Unlock BPM" → all editing controls should become enabled again
Verify the button state persists when navigating between tracks

Before Screenshot

After Video

Lock_Unlock.BPM.-.Track.Editor.dialog.mp4

ronso0

Thanks for working on this!
Though it needs a slight rework, see my comments

Swarnadip-Kar · 2026-02-23T11:19:29Z

Thanks for the review @ronso0! I've addressed all three points:

Removed checkable property from the bpmLock button in the .ui file
Added m_bpmLocked bool member to track the lock state locally instead of relying on button check state
Deferred applying the lock — setBpmLocked() now only happens in saveTrack() (i.e. on Apply/OK)

Also renamed updateBpmLockButton() to updateBpmEditControls() to better reflect its purpose, and connected to clicked() instead of toggled().

Swarnadip-Kar · 2026-02-23T11:37:56Z

Realized I accidentally removed the QSignalBlocker header — it's still used elsewhere in the file. Added it back in the same commit.

ronso0

Thank you, I left some comments

Swarnadip-Kar · 2026-02-25T06:32:15Z

Thanks for the thorough review @ronso0! Addressed all 6 points in the
new commit:

Removed the two explanatory comments in init() and saveTrack()
Fixed the BPM lock to go through m_trackRecord.setBpmLocked()
instead of directly on m_pLoadedTrack, consistent with how all
other properties are saved
Removed comment above slotBpmLockClicked()
Moved m_bpmLocked initialization from header to constructor
Removed hardcoded "Lock BPM" text from .ui file to avoid
duplicate tr() strings

Let me know if anything else needs changing!

Swarnadip-Kar · 2026-02-25T06:38:20Z

I noticed the lock button no longer turns blue/highlighted
when BPM is locked — the checkable property was lost in the refactor.

Fix would be re-adding checkable: true to the .ui and syncing with
bpmLock->setChecked(m_bpmLocked) in updateBpmEditControls().
Should I add this as a commit here?

ronso0 · 2026-02-25T11:38:43Z

IMO we don't need the button state/highlight. The BPM controls being greyed out and the button text are sufficient.
An icon would be nice, like we have it in the beatgrid controls section.
We may add that later on.

ronso0

A few last cleanup requests (sorry, didn't check the ctor and overlooked the other one earlier)

Swarnadip-Kar · 2026-02-26T05:35:23Z

All review comments addressed:

-Remove m_bpmLocked init from ctor since it is set in
reloadTrackBeats() before it is read, like m_trackHasBeatMap.
-Remove editingEnabled intermediate variable in
updateBpmEditControls() and inline !m_bpmLocked directly."

Thanks for the review, @ronso0!

Swarnadip-Kar · 2026-03-04T06:48:18Z

The CI failure in appstreamcli validate seems unrelated to my changes — it's flagging a 403 on the donate URL and a missing content rating in org.mixxx.Mixxx.metainfo.xml, both of which don't appear to be related to my changes. Is this expected and safe to ignore?
@ronso0 — gentle ping when you get a chance!

ronso0 · 2026-03-04T09:40:09Z

+    // This will only be written back to the track on Apply/OK.
+    m_bpmLocked = track.isBpmLocked();
+
+    tabBPM->setEnabled(true);


This is not needed here anymore since we now have updateBpmEditControls() (and wrong if BPM are locked)

Good catch — removed tabBPM->setEnabled(true) since updateBpmEditControls() already handles that correctly.

ronso0 · 2026-03-04T09:41:07Z

Looks good otherwise 👍

ronso0 · 2026-03-04T09:42:30Z

Yes, the CI fail is unrelated. The site seems to be n/a temporarily, or probably just requires a more relaxed timeout, idk.

Swarnadip-Kar · 2026-03-04T10:18:04Z

Yes, the CI fail is unrelated. The site seems to be n/a temporarily, or probably just requires a more relaxed timeout, idk.

Thanks for confirming!

Swarnadip-Kar · 2026-03-04T10:24:53Z

Addressed review comments — removed tabBPM->setEnabled(true) since updateBpmEditControls() already handles that correctly, and updated the doc comment to use ///.

ronso0 · 2026-03-04T10:50:15Z

Alright, now please squash the commits and we're ready to roll!

Btw how much ai did you use for this PR? I just noticed the extensive commit messages and wanna let you know that we don't need those for rather small commits like this one. If anyone is interested, either the commit itself should be clear and if not, they can look up all details/discussion in the PR as that is shown in the git history after merging it.

Swarnadip-Kar · 2026-03-04T10:55:42Z

Alright, now please squash the commits and we're ready to roll!

Squashing now..

Btw how much ai did you use for this PR?

In My inital days I used AI to understand the Codebase and find the right files to edit.
Commit messages were AI-assisted for formatting. The code and debugging was mine. Will keep commit messages shorter going forward, noted!

Swarnadip-Kar · 2026-03-04T11:55:21Z

@ronso0 Squashed and force-pushed

Swarnadip-Kar · 2026-03-06T05:56:26Z

@ronso0 did this slip from cache? 😄

ronso0 · 2026-03-06T23:03:18Z

Naa, just other stuff going on. I see you're motivated and eager to get this merged, but priorities shift on a daily basis, so please be patient.
I've planned to do one more thoutough review and test it during the weekend, monday latest.

Swarnadip-Kar · 2026-03-07T01:21:43Z

Naa, just other stuff going on. I see you're motivated and eager to get this merged, but priorities shift on a daily basis, so please be patient. I've planned to do one more thoutough review and test it during the weekend, monday latest.

Of course, take your time! Really appreciate it

ronso0

Looks good, except the indentation.
Please fix that, then we can merge.

ronso0 · 2026-03-09T13:31:36Z

Thanks, now squash & force-push please ; )

Swarnadip-Kar · 2026-03-09T14:25:32Z

Thanks, now squash & force-push please ; )

Squashed and force-pushed!

ronso0 · 2026-03-09T14:35:48Z

Thanks, now squash & force-push please ; )

Squashed and force-pushed!

Yes, but you also rebased onto main it seems. Which leads to a potentially huge Compare view where the actual PR changes (there should be none when squashing) are hard to spot. Not a big deal for this PR.
Next time just rebase onto [first commit]^1 to have a clean Compare view.

Swarnadip-Kar · 2026-03-09T14:42:21Z

Yes, but you also rebased onto main it seems. Which leads to a potentially huge Compare view where the actual PR changes (there should be none when squashing) are hard to spot. Not a big deal for this PR.
Next time just rebase onto [first commit]^1 to have a clean Compare view.

Thanks for the tip! Will research and do better next time ...

Rebased onto main after BPM lock toggle merge (mixxxdj#16025). Ensures 5/4 and 4/5 scaling buttons respect the BPM lock state, consistent with existing scaling controls.

github-actions Bot added the library label Feb 22, 2026

Swarnadip-Kar changed the title ~~DlgTrackInfo: add BPM lock/unlock toggle to BPM tab~~ Add BPM lock/unlock toggle to BPM tab Feb 22, 2026

Swarnadip-Kar changed the title ~~Add BPM lock/unlock toggle to BPM tab~~ DlgTrackInfo: add BPM lock toggle to BPM tab Feb 22, 2026

Swarnadip-Kar marked this pull request as draft February 22, 2026 12:04

Swarnadip-Kar marked this pull request as ready for review February 22, 2026 14:01

ronso0 requested changes Feb 23, 2026

View reviewed changes

Comment thread src/library/dlgtrackinfo.cpp Outdated

Comment thread src/library/dlgtrackinfo.cpp Outdated

Comment thread src/library/dlgtrackinfo.ui Outdated

Swarnadip-Kar force-pushed the add_bpm_lock_to_dlgtrackinfo branch from 8faf463 to 0bc0301 Compare February 23, 2026 11:17

Swarnadip-Kar requested a review from ronso0 February 23, 2026 11:28

Swarnadip-Kar force-pushed the add_bpm_lock_to_dlgtrackinfo branch from 0bc0301 to 6f58ca1 Compare February 23, 2026 11:37

ronso0 reviewed Feb 25, 2026

View reviewed changes

Swarnadip-Kar requested a review from ronso0 February 25, 2026 06:32

ronso0 reviewed Feb 25, 2026

View reviewed changes

Comment thread src/library/dlgtrackinfo.cpp Outdated

Comment thread src/library/dlgtrackinfo.cpp Outdated

Swarnadip-Kar force-pushed the add_bpm_lock_to_dlgtrackinfo branch from 38a5d23 to 028dc25 Compare February 26, 2026 05:31

Swarnadip-Kar requested a review from ronso0 February 26, 2026 05:34

Swarnadip-Kar mentioned this pull request Feb 28, 2026

Fix #10209: Show message when rescanning with no library folders #15972

Merged

ronso0 reviewed Mar 4, 2026

View reviewed changes

Comment thread src/library/dlgtrackinfo.cpp Outdated

ronso0 reviewed Mar 4, 2026

View reviewed changes

Swarnadip-Kar requested a review from ronso0 March 4, 2026 10:25

Swarnadip-Kar force-pushed the add_bpm_lock_to_dlgtrackinfo branch from c346c55 to 8eb0d14 Compare March 4, 2026 11:22

ronso0 approved these changes Mar 9, 2026

View reviewed changes

Comment thread src/library/dlgtrackinfo.ui Outdated

Swarnadip-Kar requested a review from ronso0 March 9, 2026 13:18

DlgTrackInfo: add BPM lock toggle to BPM tab

6af523c

Swarnadip-Kar force-pushed the add_bpm_lock_to_dlgtrackinfo branch from 2ff5bc6 to 6af523c Compare March 9, 2026 14:25

ronso0 enabled auto-merge March 9, 2026 14:35

ronso0 merged commit 68ba17a into mixxxdj:main Mar 9, 2026
17 checks passed

Swarnadip-Kar mentioned this pull request Mar 9, 2026

DlgTrackInfo: add editable tuning field #16029

Merged

Swarnadip-Kar mentioned this pull request Mar 9, 2026

Add 5/4 and 4/5 BPM scaling controls #16026

Merged

Swarnadip-Kar deleted the add_bpm_lock_to_dlgtrackinfo branch March 28, 2026 05:05

ronso0 mentioned this pull request Apr 28, 2026

(fix) Track: emit bpmLockChanged when updating TrackRecord so bpmlock control is also updated #16408

Merged

Uh oh!

Uh oh!

Conversation

Swarnadip-Kar commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Changes

How to test

Before Screenshot

After Video

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Swarnadip-Kar commented Feb 23, 2026

Uh oh!

Swarnadip-Kar commented Feb 23, 2026

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Swarnadip-Kar commented Feb 25, 2026

Uh oh!

Swarnadip-Kar commented Feb 25, 2026

Uh oh!

ronso0 commented Feb 25, 2026

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Swarnadip-Kar commented Feb 26, 2026

Uh oh!

Swarnadip-Kar commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ronso0 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Swarnadip-Kar Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Mar 4, 2026

Uh oh!

ronso0 commented Mar 4, 2026

Uh oh!

Swarnadip-Kar commented Mar 4, 2026

Uh oh!

Swarnadip-Kar commented Mar 4, 2026

Uh oh!

ronso0 commented Mar 4, 2026

Uh oh!

Swarnadip-Kar commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Swarnadip-Kar commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Swarnadip-Kar commented Mar 6, 2026

Uh oh!

ronso0 commented Mar 6, 2026

Uh oh!

Swarnadip-Kar commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Swarnadip-Kar commented Feb 22, 2026 •

edited

Loading

Swarnadip-Kar commented Mar 4, 2026 •

edited

Loading

Swarnadip-Kar commented Mar 4, 2026 •

edited

Loading

Swarnadip-Kar commented Mar 4, 2026 •

edited

Loading

Swarnadip-Kar commented Mar 7, 2026 •

edited

Loading