AutoDJProcessor refactoring and split into separate files by fonsargo · Pull Request #16050 · mixxxdj/mixxx

fonsargo · 2026-02-26T21:47:01Z

This MR is all refactorings from #13183 carefully cherry-picked by me. I also removed some leftovers from new feature, so this MR doesn't contain anything new at all.

Main changes:

Add new abstractions like TrackOrDeckAttributes, FadeableTrackOrDeckAttributes, TrackAttributes
Extract logic from calculateTransition() to calculateTransitionImpl()
Rename some variables
Fix spelling and grammar errors

This is a first step in generalizing the transition logic in AutoDJProcessor to enable it to also be applied to tracks in the queue instead of just the current decks.

This is another step in generalizing the transition logic in AutoDJProcessor to enable calculating transition times for the whole queue.

This is the final step in generalizing the core transition timing logic in AutoDJProcessor, so that it can be applied to a whole playlist instead of just the current decks.

… separate files.

acolombier

Thank you for turning the situation around!
I have shared a first pass of review and will let @daschuer do the final one as he raised elements of the rebased PR.

acolombier · 2026-02-27T19:22:17Z

+    ControlProxy m_trackSamples;
+    ControlProxy m_sampleRate;
+    ControlProxy m_rateRatio;
+    BaseTrackPlayer* m_pPlayer;


We aim to avoid fat pointer, is there any chance to use smart pointer? Note that you may also consider our parented_ptr wrapper that ensure that fat pointer are at least parented, and thus would be deallocated when their parent is released.

To be honest I don't know how to answer to this question. The object is created and parented in PlayerManager.
I am not the owner of its lifetime. However if we want to avoid pointer here, then it requires a lot of refactoring.

Right, that makes sense. In this case you can use parented_ptr. The crux of it is here. It is basically a thin layer, which will help us to catch memory leak in case in changes is done in PlayerManager.
For you, it should change anything: you can dereference it like a pointer and nothing will happen to it (e.g auto dealloc)

Just the following change should be enough to use this wrapper:

Suggested change

BaseTrackPlayer* m_pPlayer;

parented_ptr<BaseTrackPlayer> m_pPlayer;

Check, got it! I changed fat pointer to parented ptr as you suggested and replaced

return m_pPlayer != nullptr ? m_pPlayer->getLoadedTrack() : TrackPointer();

with

return m_pPlayer ? m_pPlayer->getLoadedTrack() : TrackPointer();

in DeckAttributes::getLoadedTrack(). I think it should work.

…Impl()

acolombier

Thanks for addressing the feedback - I spotted one miss on my end.

acolombier · 2026-03-03T23:10:32Z

+            FadeableTrackOrDeckAttributes& fromTrack,
+            FadeableTrackOrDeckAttributes& toTrack,


Let's apply the const-correctness principle here too.

Suggested change

FadeableTrackOrDeckAttributes& fromTrack,

FadeableTrackOrDeckAttributes& toTrack,

const FadeableTrackOrDeckAttributes& fromTrack,

const FadeableTrackOrDeckAttributes& toTrack,

In case you need them to remain mutable, you should keep the fat pointers

Changed it back to fat pointers according to the const-correctness principle.

fonsargo · 2026-03-26T21:32:55Z

I've fixed compile error for other platforms (somehow on Windows it worked fine), however now I see that build is failing for Android 15 (before that it was green 🤔 ). Any suggestions how to fix it?

btoplak · 2026-04-08T08:45:10Z

I've fixed compile error for other platforms (somehow on Windows it worked fine), however now I see that build is failing for Android 15 (before that it was green 🤔 ). Any suggestions how to fix it?

I can't promise anything cause I'm busy rn, but if I get some free time this weekend I'll download your fork and try to build it, maybe I get some ideas...

fonsargo · 2026-04-09T19:32:47Z

@btoplak I guess it's not connected with the changes, maybe I just need to rebase the branch. I'll try it when I have some time

github-actions · 2026-07-11T00:25:16Z

This PR is marked as stale because it has been open 90 days with no activity.

cr7pt0gr4ph7 · 2026-08-09T21:04:18Z

Now that:

exists (which is my rebase of #13183), this PR can probably be closed.

Thanks to @fonsargo for picking this up when I wasn't able to work on this in the last two years!

cr7pt0gr4ph7 and others added 10 commits February 17, 2026 21:57

AutoDJProcessor: Add TrackOrDeckAttributes

beed3ac

This is a first step in generalizing the transition logic in AutoDJProcessor to enable it to also be applied to tracks in the queue instead of just the current decks.

AutoDJProcessor: Add FadeableTrackOrDeckAttributes

90800ad

This is another step in generalizing the transition logic in AutoDJProcessor to enable calculating transition times for the whole queue.

AutoDJProcessor: Add calculateTransitionImpl

f886172

This is the final step in generalizing the core transition timing logic in AutoDJProcessor, so that it can be applied to a whole playlist instead of just the current decks.

AutoDJProcessor: Readability: Append "Second" suffix to variables

b485983

AutoDJProcessor: Readability: Shorten variable names

b79fabc

AutoDJFeature: Fix spelling of 'findOrCreateAutoDjPlaylistId'

2148b03

AutoDJConstants: Extract common constants into AutoDJConstants.

35b4bae

TrackOrDeckAttributes: Move TrackOrDeckAttributes and subclasses into…

3c908ff

… separate files.

AutoDJProcessor: Fix a few spelling and grammar errors.

8908f15

Remove new feature leftovers: fadeDurationSeconds

9a53b06

github-actions Bot added library build autodj labels Feb 26, 2026

acolombier reviewed Feb 27, 2026

View reviewed changes

acolombier requested a review from daschuer February 27, 2026 19:38

fonsargo added 4 commits March 3, 2026 22:48

Use PollingControlProxy instead of ControlProxy

00e875f

Use setters & getters in FadeableTrackOrDeckAttributes

edfa17c

Use namespaces for constants

5bc8810

Use pointers for FadeableTrackOrDeckAttributes in calculateTransition…

168fccf

…Impl()

acolombier reviewed Mar 3, 2026

View reviewed changes

fonsargo added 3 commits March 17, 2026 20:37

Use fat pointers for FadeableTrackOrDeckAttributes in useFixedFadeTime()

404db53

Use parented_ptr for BaseTrackPlayer

b826310

Include parented_ptr.h

ea8eba7

github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Jul 11, 2026

	BaseTrackPlayer* m_pPlayer;
	parented_ptr<BaseTrackPlayer> m_pPlayer;

		FadeableTrackOrDeckAttributes& fromTrack,
		FadeableTrackOrDeckAttributes& toTrack,

Uh oh!

Uh oh!

Conversation

fonsargo commented Feb 26, 2026

Uh oh!

acolombier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acolombier Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

fonsargo Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

acolombier Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

fonsargo Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acolombier left a comment

Choose a reason for hiding this comment

Uh oh!

acolombier Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

fonsargo Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

fonsargo commented Mar 26, 2026

Uh oh!

btoplak commented Apr 8, 2026

Uh oh!

fonsargo commented Apr 9, 2026

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

cr7pt0gr4ph7 commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fonsargo Mar 17, 2026 •

edited

Loading

cr7pt0gr4ph7 commented Aug 9, 2026 •

edited

Loading