Skip to content

Avoid conditional jump that depends on uninitialized memory #16052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acolombier merged 1 commit into from
Mar 1, 2026
Merged

Avoid conditional jump that depends on uninitialized memory #16052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/library/columncache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,9 @@ ColumnCache::ColumnCache() {
m_pKeyNotationCP = new ControlProxy(mixxx::library::prefs::kKeyNotationConfigKey, this);
m_pKeyNotationCP->connectValueChanged(this, &ColumnCache::slotSetKeySortOrder);

// Used in BaseTrackTableModel() along with a later setColumns() call.
// ColumnCache is initialized before the preferences, so slotSetKeySortOrder is called
// for again if DlgPrefKey sets the [Library]. key_notation CO to a value other than
// again if DlgPrefKey sets the [Library]. key_notation CO to a value other than
// KeyUtils::CUSTOM as Mixxx is starting.
}

Expand Down Expand Up @@ -240,6 +241,10 @@ void ColumnCache::setColumns(QStringList columns) {
}

void ColumnCache::slotSetKeySortOrder(double notationValue) {
if (m_columnsByIndex.isEmpty()) {
// we are not caching columns yet
return;
}
const int keyColumnIndex = m_columnIndexByEnum[COLUMN_LIBRARYTABLE_KEY];
if (keyColumnIndex < 0) {
return;
Expand Down