fixed glitch effect by removing cast to integer - #16068
Merged
Merged
Conversation
daschuer
approved these changes
Mar 1, 2026
daschuer
left a comment
daschuer
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you for finding and fixing it.
Member
|
The pre-commit issue is unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glitch effect doesn't worked when it was used with tracks that have a BPM value because delay_seconds was calculated with an integer cast.
The result was that delay_seconds was 0 (except of tracks with a low BPM value) and in this case the input buffer was just copied to the output buffer.