Add Pioneer DDJ SX2 Mapping#16372
Draft
Krafting wants to merge 2 commits into
Draft
Conversation
…laying, add quantize, loop anchor and revamp Flip buttons https://mixxx.discourse.group/t/pioneer-ddj-sx2-mapping/33575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of the Pioneer DDJ-SX2 controller. Supports most features mentioned in the manual. (Some are not possible, for example the Flip controls)
Related documentation is at mixxxdj/manual#877
There is an area of the mapping I would love to get help with though, nothing blocking this PR, but if anyone would like to help, it's about the Slicer mode is just some beatjump rightnow, but it would be great to have a real Slicer
There is also the Slicer Loop mode that does the exact same as the current slicer mode (beatjump), I might use it for STEMs support later on when 2.6 comes around, or if anyone have any better ideas ! :)
By the way, the code lives here too : https://gitlab.com/Krafting/mixxx-pioneer-ddj-sx2
p.s. This is my first mapping contribution, please tell me if I'm doing anything wrong!
This is based on tildearrow's mapping ( https://github.com/tildearrow/Mixxx-Pioneer-DDJ-SX2 ), heavily modified by myself and eXWoLL1