Improve QML library - #16668
Conversation
e41f343 to
2ff0e17
Compare
c2eb3e3 to
ac3ec7f
Compare
|
Long term, LateNightQML should move out from behind The better intermediate step is to guard the special profile-risk bypass behind the |
|
@xARSENICx it seems you mixed the commits here. 881d9d7 is the commit that ensure that the QML testcases work. And that changes on new-ui do not break LateNightQML and vice versa. It prevents also annoying case that a user double clicks on Mixxx and nothing happens because main.qml could not load and generate alien processes which can only killed by task manager. |
JoergAtGithub
left a comment
There was a problem hiding this comment.
Please restore that the behavior that Mixxx fails, if QML is not loadable. You might bypass it by a combination like --new-ui and --developer, but for normal users and the unit tests it must fail reliable.
ac3ec7f to
fe6838c
Compare
|
The QML interface is highly unstable and this kind of early changes prevent fast prototyping. I have reworked it so the behaviour continue allowing failure if if
Could you please clarify how is this test useful for unit test? I understand that having |
fe6838c to
0ccd766
Compare
65dd088 to
4904596
Compare
65b7e6c to
bc03f1a
Compare
Depends on #16658
Refactor the QML library to reduce the node count and reduce the strain on the data model. Also leverage some of the Qt 6.5+ and 6.8+ TableView improvement to provide a full table customisation experience (column resizing, moving, filtering,...)
This is providing a net performance improvement!
@xARSENICx I have reverted 881d9d7 as it made the devx absolutely dreadful: any invalid work in progress would lead to Mixxx stopping, forcing the restart the debug session every time. What was the reason for making this change? Arguably, we could guard it being the
--developerflag?