DlgPrefLibrary: add option to reset missing tags on import - #16788
Open
gary-gdbsystems wants to merge 2 commits into
Open
DlgPrefLibrary: add option to reset missing tags on import#16788gary-gdbsystems wants to merge 2 commits into
gary-gdbsystems wants to merge 2 commits into
Conversation
The ResetMissingTagMetadataOnImport behavior already existed (DlgTrackInfo::slotImportMetadataFromFile reads the config key directly), but there was no UI to enable it. As a result "Import From File Tags" would not clear library fields such as Album Artist that had been emptied by another tag editor. Add a standalone checkbox in Library preferences (Track Metadata Synchronization) bound to kResetMissingTagMetadataOnImportConfigKey: loaded in slotUpdate(), saved in slotApply(), reset in slotResetToDefaults(). The manual import path reads the key directly and is not gated on metadata syncing, so this is an independent option rather than a sub-option of "Synchronize library track metadata". As requested by the maintainers in mixxxdj#11241, whose remaining work was exposing this existing config key in the UI. Resolves mixxxdj#11241.
ronso0
added
the
AI
The new checkbox was missing from the dialog's explicit <tabstops> order, so keyboard Tab navigation skipped it. Insert it between the Serato and relative-path checkboxes to match its visual position.
gary-gdbsystems
force-pushed
the
library-reset-missing-tags-pref
branch
from
August 11, 2026 22:03
d9811bb to
995be45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #11241.
The
ResetMissingTagMetadataOnImportbehavior already exists in the backend —DlgTrackInfo::slotImportMetadataFromFile()readskResetMissingTagMetadataOnImportConfigKeydirectly — but there was no UI to enable it. As reported, this meant "Import From File Tags" would not clear a library field such as Album Artist after it had been emptied in another tag editor.Per @uklotzde in the issue thread, the only missing piece was "a UI option for
kResetMissingTagMetadataOnImportConfigKey" — this PR adds exactly that.Approach
Add a standalone checkbox "Reset missing metadata fields when reimporting from file tags" to Library preferences → Track Metadata Synchronization, bound to the existing config key:
slotUpdate()slotApply()slotResetToDefaults()The manual import path reads the key directly and is not gated on
kSyncTrackMetadataConfigKey, so this is an independent option rather than a sub-option of "Synchronize library track metadata".Changes
src/preferences/dialog/dlgpreflibrarydlg.ui— new checkbox in the metadata group.src/preferences/dialog/dlgpreflibrary.cpp— load/save/default wiring.Screenshots
Before — sync / Serato / relative paths:
After — adds “Reset missing metadata fields when reimporting from file tags”:
Testing
uicregeneration of the dialog).