Skip to content

Numark Mixtrack Go controller mapping: Add controller mapping - #16813

Open
josefveiga wants to merge 6 commits into
mixxxdj:2.6from
josefveiga:2.6
Open

Numark Mixtrack Go controller mapping: Add controller mapping#16813
josefveiga wants to merge 6 commits into
mixxxdj:2.6from
josefveiga:2.6

Conversation

@josefveiga

@josefveiga josefveiga commented Aug 1, 2026

Copy link
Copy Markdown

Manual page: mixxxdj/manual#907

@josefveiga josefveiga mentioned this pull request Aug 1, 2026
Open
acolombier
acolombier reviewed Aug 1, 2026
View reviewed changes
Comment thread res/controllers/Numark-Mixtrack-Go.scripts.js Outdated
Comment thread res/controllers/Numark-Mixtrack-Go.scripts.js Outdated
Comment thread res/controllers/Numark-Mixtrack-Go.scripts.js Outdated
@josefveiga
Numark Mixtrack Go mapping: general code improvements
8bdd99c 
The encoder knob mode now correctly persists through a script reload.
Constants at the top pf the .js were removed.
STEMS track loading is now identified with an engine.makeConnection.
@josefveiga

josefveiga commented Aug 1, 2026

Copy link
Copy Markdown
Author

My last commit passed the eslint check: npx eslint -c eslint.config.js ./res/controllers/Numark-Mixtrack-Go.scripts.js
But i forgot forgot to install pre-commit so that check was not done.
Now i have installed pre-commit and without changing the .js file i have this error that i don't know how to solve:
`git commit
fix utf-8 byte order marker..............................................Passed
check for case conflicts.................................................Passed
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
check xml............................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.............................(no files to check)Skipped
don't commit to branch...................................................Failed

  • hook id: no-commit-to-branch
  • exit code: 1
    codespell................................................................Passed
    eslint...................................................................Passed
  • hook id: eslint
  • duration: 2.19s
    clang-format.........................................(no files to check)Skipped
    black................................................(no files to check)Skipped
    flake8...............................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    markdownlint-cli2....................................(no files to check)Skipped
    Validate GitHub Workflows............................(no files to check)Skipped
    prettier.............................................(no files to check)Skipped
    reformat QML files...................................(no files to check)Skipped
    gersemi..............................................(no files to check)Skipped
    CMake Lint...........................................(no files to check)Skipped
    qsscheck.............................................(no files to check)Skipped
    changelog............................................(no files to check)Skipped
    qmllint..............................................(no files to check)Skipped
    metainfo.............................................(no files to check)Skipped
    ts-source-copy.......................................(no files to check)Skipped
    check-ui-buddies.....................................(no files to check)Skipped`

The previous commit has the same code as the one that fails this pre-commit.

@josefveiga
josefveiga requested a review from acolombier August 3, 2026 09:46
@josefveiga
Numark Mixtrack Go mapping: Bug Fix
650f0b1 
Strip searching the track in the preview deck with the endless encoder now correctly moves the trackhead 5% of the track length per encoder detent.
@josefveiga
Merge branch 'mixxxdj:2.6' into 2.6
e897fb1
@josefveiga
Numark Mixtrack Go mapping: Bug Fix and linting
d0b760b 
Fix bug where using the script in a Mixxx version < 2.6 would crash during the init() function.
Move declaration of variables drumsStemGroup, bassStemGroup, synthsStemGroup, voiceStemGroup up the code to avoid linting warnings.
@josefveiga
Merge remote-tracking branch 'refs/remotes/origin/2.6' into 2.6
904a653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acolombier acolombier Awaiting requested review from acolombier

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

controller mappings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josefveiga @acolombier