MIDI Controller preferences: improve UX with MIDI options - #16851
Open
ronso0 wants to merge 4 commits into
Open
Conversation
Member
Author
|
based on 2.6 because it's an UX fix (-> 2.6 / 2.6.1), but can also go to main if desired |
cr7pt0gr4ph7
approved these changes
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Looks good to me 👍
As an aside, it would make sense to change the PR title to "Midi Controller preferences: Allow non-exclusive MIDI options to be combined", as this touches the implementation in midicontroller.cpp as well as the UX in the preferences dialog.
ronso0
force-pushed
the
midi-option-exclusive
branch
from
August 12, 2026 07:54
8e431ce to
95569bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally addressing a TODO I left in #12348 (allows users to set multiple MIDI options with the GUI)
This adds protection to avoid combining exclusive (= incompatible) options, eg.
Rot64andHercJog.The options list is now updated on the fly when an exclusive option is ticked, meaning even when using Spacebar in the list view, we immediately get a reasonable state.