Database: Make it possible to trigger the "Repair Database" action via CLI option and menu item - #16855
Database: Make it possible to trigger the "Repair Database" action via CLI option and menu item #16855cr7pt0gr4ph7 wants to merge 2 commits into
Conversation
2ca6550 to
b35c626
Compare
…a --repair-database CLI option
b35c626 to
ea209de
Compare
| pOptionsMenu->addSeparator(); | ||
|
|
||
| QString repairDatabaseTitle = tr("Repair Database"); | ||
| QString repairDatabaseText = tr("Restart Mixxx & repair database inconsistencies"); |
There was a problem hiding this comment.
| QString repairDatabaseText = tr("Restart Mixxx & repair database inconsistencies"); | |
| QString repairDatabaseText = tr("Repair database inconsistencies on next launch"); |
to not imply that Mixxx quits and restarts by itself.
I know this is more clear in the message box in MixxxMainWindow::slotOptionsRepairDatabase(), but with the "Restart .." title I'd hesitate to click this because it sounds like it would restart immediately
There was a problem hiding this comment.
Oh sorry, it does quit right away.
Guess this is desired behavior, because why feel the urge to cleanup the db and not do it right away..
There was a problem hiding this comment.
Yeah, it should quit right away because that's needed for the DB cleanup. Either you want to repair the database, or you don't. Ideally it would also restart Mixxx, but that would require an external wrapper application AFAICT, and is probably best left to a separate PR.
2 participants
I can split this into two separate PRs, but have kept is as one PR for now because updating the comment in
trackcollectionmanagerwould cause a merge conflict anyway.$ ./mixxx --help Usage: ./mixxx [options] file Mixxx is an open source DJ software. For more information, see: https://manual.mixxx.org/2.7/chapters/appendix/commandline_dev_tools.html Options: [...] --repair-database Run a database cleanup when Mixxx is launched. [...]