Fix #16848 slip mode rendering in split stem view - #16856
Open
PredellaN wants to merge 1080 commits into
Open
Conversation
Fixes mixxxdj#16520 which was introduced in 548094e.
Merge changes from `2.6` into `main`
…l_rendergraph Make warnings fatal in mixxx-qml-lib and rendergraph
build: Update Qt policy QTP0004 to suppress deprecation warnings
…nterface-waveform-cpp
…terface-waveform-cpp Add rendergraph capabilities for full support on QML
This would break the filter.
Computes the phase difference of two given samples of a sine and cosine pair.
It is actually an exponential weighted moving average filter.
Preparation for the instantaneous frequency detector, which requires the derivative of the signal to be taken also for non-MK2 timecodes.
Rename struct pitch to struct pitch_filter, as this is more correct. Also needed to make room for the new tc->pitch value.
Also reorder the values for better readability.
Completely substitutes the xwax legacy pitch detection with an instantaneous frequency detector that updates the pitch on every sample, as opposed to only when zero crossings are detected. This improves latency, sticker drift and stability of the pitch.
…efficients Testing showed that too many mode switches increase sticker drift. The new frequency detector also provides smoother output without those switches.
Without a small dot can be visible when the record is not spinning.
Was at 15 fps before. It feels better with 30.
Some minor conistencency cleanups.
The library is needed for the Savitzky-Golay filter.
Implement a Savitzky-Golay filter according to https://c.mql5.com/forextsd/forum/147/sgfilter.pdf which efficiently smooths a signal without filtering out wanted frequency components.
This replaces xwax' rumble filter in the detect_zero_crossing() function for the new pitch detection logic.
pitch detection logic
This filter version takes the timecode carrier frequency and sampling rate into account.
Adds tests for the single functions of the matrix API, which is used to generate the Savitzky-Golay filter.
Merge changes from `2.6` into `main`
Merge changes from `2.6` into `main`
Merge changes from `2.6` into `main`
…k-effect QML: enable Quick.Effects on Windows and Mac
…21 already existing)
…/mixxxdj/mixxx2-7/. Compile QM files out of TS files that are used by the localized app
…rart Track Info Dialog: Add tooltip to cover art image
…dy been implemented
CrateFeature: Remove outdated refactoring TODO comment that has already been implemented
Member
|
There appear some orange artifacts, when slip mode is activated: Aufzeichnung.2026-08-09.143957.mp4 |
Author
Interesting... I didn't get those but I'll try to reproduce the issue. This doesn't happen in overlapping mode? |
Member
|
Just checked, it also happens with overlay mode |
Author
I am unable to reproduce the issue (neither in overlapping nor in stacked), can you check if this issue is absent in main? |
Member
|
Thisorange flickering is not related to this PR. It is also in main and affects not only STEM files. But I found out, that it only appears with hardware-accelerated RGB waveforms: Aufzeichnung.2026-08-09.200259.mp4 |
JoergAtGithub
approved these changes
Aug 13, 2026
JoergAtGithub
left a comment
JoergAtGithub
left a comment
Member
There was a problem hiding this comment.
The artifacts are unrelated to this PR. The implemented slip functionality works flawless. Code looks good! Thank you for addressing this!
Member
|
I changed this PRs target to 2.6, as this fixes an issue in 2.6. Could you please rebase your branch to 2.6 therefore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes slip mode for stacked stem visualization: each stem waveform is split in two parts.