Skip to content

don't reset beatloop_size to 1/32 when loop doesn't match any of the pre-defined sizes #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronso0 wants to merge 1 commit into
base: 2.5
Choose a base branch
from
+7 −1
Open

don't reset beatloop_size to 1/32 when loop doesn't match any of the pre-defined sizes #16881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/engine/controls/loopingcontrol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,14 @@ void LoopingControl::setLoop(mixxx::audio::FramePos startPosition,
}

// Don't allow loop size widget setting to trigger creation of another loop.
double loaded_loop_size = findBeatloopSizeForLoop(startPosition, endPosition);
if (loaded_loop_size == -1) {
// Loop size doesn't match any of the pre-defined sizes,
// keep the current size
return;
}
m_pCOBeatLoopSize->blockSignals(true);
m_pCOBeatLoopSize->setAndConfirm(findBeatloopSizeForLoop(startPosition, endPosition));
m_pCOBeatLoopSize->setAndConfirm(loaded_loop_size);
m_pCOBeatLoopSize->blockSignals(false);
}

Expand Down
Loading